fix(benchmarks): prevent csv correctness harness from crashing on rai…#589
Open
adiraj66132 wants to merge 2 commits into
Open
fix(benchmarks): prevent csv correctness harness from crashing on rai…#589adiraj66132 wants to merge 2 commits into
adiraj66132 wants to merge 2 commits into
Conversation
The test required pandas, which isn't always available locally; the correctness harness is generic, so a stdlib csv one-liner exercises the same gate logic without an external dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
csv()correctness harness in benchmarks/correctness.js crashed withAttributeError: '_io.TextIOWrapper' object has no attribute 'getvalue'whenever the generated code raised inside its
try:block. Theexceptbranch restored
sys.stdoutto the real stream, then the next line called.getvalue()on it — so the real error was swallowed and masked by amisleading Python traceback.
Fix
Keep a reference to the captured
StringIObuffer (_captured) and emit aclean
FAILon exception instead of silentlypass-ing.Test plan