Upgrade snakeyaml to 2.4 and raise Java baseline to 1.8#796
Open
dimakai wants to merge 1 commit into
Open
Conversation
- Bump org.yaml:snakeyaml from 1.26 to 2.4 (latest) - Drop the android classifier (no longer published in snakeyaml 2.x) - Raise maven-compiler-plugin source/target from 1.6 to 1.8 (snakeyaml 2.x requires Java 8+, and modern JDKs no longer compile for 1.6) - Add FakeValuesTest coverage for YAML sequence/mapping deserialization and value caching under snakeyaml's 2.x safe loader - Update README.md and CONTRIBUTING.md to reflect the Java 1.8 baseline and current Android support story (desugaring, no android artifact needed) Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
org.yaml:snakeyaml:1.* is a security vulnerability |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernizes the dependency stack so the project can stay on maintained releases. Upgrades
org.yaml:snakeyamlfrom1.26to2.4(the latest release) and raises the Java compatibility baseline from 1.6 to 1.8.Changes
org.yaml:snakeyaml1.26→2.4.androidclassifier — it is no longer published in the snakeyaml 2.x line and is no longer needed (see Android note below).maven-compiler-pluginsource/targetfrom1.6→1.8. snakeyaml 2.x requires Java 8+, and modern JDKs can no longer compile for Java 6 (Source option 6 is no longer supported).FakeValuesTestcases covering YAML sequence →Listand nested mapping →Mapdeserialization, plus value caching, to validate behavior under snakeyaml 2.x's safe loader (which is now the default).README.md(new Requirements section) andCONTRIBUTING.mdto reflect the Java 1.8 baseline.Why raise the baseline?
This is the main discussion point.
CONTRIBUTING.mdpreviously mandated Java 1.6 + Android. That baseline blocks every actively maintained version of common dependencies (snakeyaml, commons-lang3, etc.) and can no longer be compiled by supported JDKs. Moving to Java 1.8 keeps the library buildable and lets it receive security/bugfix updates from upstream libraries.Android support
snakeyaml dropped the separate
androidclassifier in 2.x because it is no longer necessary: modern Android (with Java 8 language desugaring) runs the standard artifact. So this change keeps Android usable while removing a dead classifier, rather than dropping Android support.Testing
mvn clean verify→ BUILD SUCCESSHappy to instead target snakeyaml
1.33(last 1.x release, retains Java 6 + the android classifier) if maintainers prefer to keep the 1.6 baseline.Made with Cursor