Skip to content

Security deps lock: npm i -> ci #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pharret31 merged 7 commits into from
Sep 10, 2025
Merged

Security deps lock: npm i -> ci #679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
66eedda
Change npm i to ci
pharret31 Sep 8, 2025
ff5ad89
Test
pharret31 Sep 8, 2025
da22759
Test
pharret31 Sep 8, 2025
01b10fc
Fix
pharret31 Sep 8, 2025
fac94e3
Fix
pharret31 Sep 8, 2025
82f08b0
Fix
pharret31 Sep 8, 2025
1115358
Fix
pharret31 Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/dotnet-test-build/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ runs:
path: ~/.nuget/packages

- shell: bash
run: cd net/Sample && npm i
run: cd net/Sample && npm ci

- shell: bash
run: dotnet build -c Debug net/DevExtreme.AspNet.Data.sln
9 changes: 6 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@ jobs:
- run: curl -L https://github.com/editorconfig-checker/editorconfig-checker/releases/download/2.3.5/ec-linux-amd64.tar.gz | tar xzf - -C /opt
- run: /opt/bin/ec-linux-amd64 -v

- run: npm i eslint
- name: Install ESLint

@ksercs ksercs Sep 10, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that eslint is listed in package.json so looks like npm ci should be able to restore necessary version without a manual search, nah?

@pharret31 pharret31 Sep 10, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Npm ci can only perform a clean install of everything that is listed in package-lock, but for the lint step we only need the eslint package, there's no reason to install all dependencies

@wdevfx wdevfx Sep 10, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's a little bit tricky approach, but formally everything alright here
We take specific version from the package-lock.json and we really need only eslint here for lint checks (for now)
So, everything legal :D

But in future, if eslint will require additional packages (such as plugins), it'll be more tricky to support it this way

run: |
ESLINT_VERSION=$(node -p "require('./package-lock.json').packages['node_modules/eslint'].version")
npm i --no-save eslint@$ESLINT_VERSION
- run: npm run eslint

test-js:
Expand All @@ -50,9 +53,9 @@ jobs:

- run: node build/make-nojquery

- run: npm i --omit=peer
- run: npm ci --omit=peer
- run: npm i --no-save "devextreme@${{ matrix.version }}"
- name: Instal devextreme-dist
- name: Install devextreme-dist
if: ${{ matrix.version == '>=23.1.0' }}
run: npm i --no-save "devextreme-dist@${{ matrix.version }}"
- run: npm run dts
Expand Down
Loading