Mfa flow editor - #3551
Open
j-chmielewski wants to merge 25 commits into
Open
Conversation
j-chmielewski
marked this pull request as ready for review
August 17, 2026 10:11
filipslezaklab
requested changes
Aug 17, 2026
| }, | ||
| }); | ||
| const form = useAppForm({ | ||
| defaultValues: flow |
| import { MfaFormPage } from '../../../../../pages/MfaPage/MfaFormPage'; | ||
| import api from '../../../../../shared/api/api'; | ||
|
|
||
| export const Route = createFileRoute('/_authorized/_default/mfa-flow/$id/edit')({ |
Contributor
There was a problem hiding this comment.
usage of loader without any loader component, we switched to skeletons a while ago.
| return (await api.mfaFlow.get(id)).data; | ||
| } catch (error) { | ||
| if (axios.isAxiosError(error) && error.response?.status === 404) throw notFound(); | ||
| throw error; |
Contributor
There was a problem hiding this comment.
this would crash the app better to throw redirect and show snackbar
| export const Route = createFileRoute('/_authorized/_default/mfa-flow/$id/edit')({ | ||
| loader: async ({ params }) => { | ||
| const id = Number(params.id); | ||
| if (!Number.isSafeInteger(id) || id <= 0) throw notFound(); |
Contributor
There was a problem hiding this comment.
if i remember correctly we have no 404 implemented yet for core.
| return undefined; | ||
| } | ||
| }; | ||
| /** Builds one selectable MFA method menu item. */ |
Contributor
There was a problem hiding this comment.
Suggested change
| /** Builds one selectable MFA method menu item. */ |
| ), | ||
| })); | ||
|
|
||
| const deleteStep = (id: MfaConfigurationStepData['id']) => { |
Contributor
There was a problem hiding this comment.
if you pass methods to components it is required to wrap them in the useCallback
| [MfaFlowMethod.Biometric]: m.mfa_flow_method_biometric(), | ||
| }; | ||
| /** Maps a backend availability reason to menu guidance. */ | ||
| const getDisabledHelper = (reason: MfaMethodAvailabilityReasonValue) => { |
Contributor
There was a problem hiding this comment.
doesn't need to be in component scope
| export const MfaConfiguration = ({ onChange, steps, error }: MfaConfigurationProps) => { | ||
| const { data: methodAvailability } = useQuery(getMfaMethodAvailabilityQueryOptions); | ||
| const availableMethods = methodAvailability?.map(({ method }) => method) ?? []; | ||
| const methodLabels: Record<MfaFlowMethodValue, string> = { |
Contributor
There was a problem hiding this comment.
doesn't need to be in component scope
|
|
||
| export const MfaConfiguration = ({ onChange, steps, error }: MfaConfigurationProps) => { | ||
| const { data: methodAvailability } = useQuery(getMfaMethodAvailabilityQueryOptions); | ||
| const availableMethods = methodAvailability?.map(({ method }) => method) ?? []; |
Contributor
There was a problem hiding this comment.
use select in query for this.
| } | ||
|
|
||
| /** MFA methods grouped for display in an add-method menu. */ | ||
| export type MfaMethodGroup = { |
Contributor
There was a problem hiding this comment.
if those are not from API then name should relate to the component used, if this is from API then it should be in api types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #3044
Implements the multi-step MFA flow editor.