Walk Red, Blue and Yellow from Lt. Surge into the Hall of Fame

[Decryptu]

Added

• The story walk runs Red, Blue and Yellow from Lt. Surge into the Hall of Fame: Rock Tunnel, Erika, the Rocket Hideout and the SILPH SCOPE, Pokemon Tower and the POKé FLUTE, Route 12's SNORLAX, Koga, the Safari Zone's HM03 and HM04, Celadon Mart's FRESH WATER for Route 7's guard, Silph Co.'s LAPRAS and CARD KEY, the rival, Giovanni and the MASTER BALL, Saffron Gym, SURF down Route 19 and Route 20 through the Seafoam Islands, the Mansion's SECRET KEY, Blaine's quiz, Route 21 to Pallet, Viridian's gym, Route 22's gate, Route 23's guards and river, Victory Road's three boulder switches, the Elite Four, Lance and the Champion. 360 steps on Red and Blue, 361 on Yellow, all eight badges.
• RomRegistry marks Red, Blue and Yellow playable, so the shelf offers Play on all three.
• The world screen answers Generation 1's HallOfFamePC request with the induction and the credits, and the jp Init behind the Hall's save with a restart; a playthrough had ended on a prompt to press A.
• The old man's catch tutorial on Red and Blue and Prof. Oak's Pikachu battle on Yellow: wBattleType maps onto the Dude's tutorial with the cartridge's own ball, back pic, cursor timings and outcome. Yellow's walk takes the Pikachu, the EEVEE ball and Damian's CHARMANDER and reaches Lt. Surge.
• gen1_walk pins the catch training, the ghost MAROWAK both ways, the Safari gate's early leave and the card key door's flag; gen1_trainers pins the three coded trainer headers a cartridge carries; gen1_maps refuses a number marker in any map script and pins the Safari fee line; gen1_battle drives the tutor's throw on every cartridge.

Fixed

• EndTrainerBattle zeroes wCurMapScript, which the silent call dropped: every Elite Four room's end-battle state, which calls it and prints on, stayed on itself and printed the after-battle line for ever.
• DisplayTextID by id is hSpriteIndex too, so a map script opening a trainer's row fights the object of that index; Lance's trigger had asked for a wild Pokemon of species 0.
• CinnabarIsland_Script sets BIT_CUR_MAP_LOADED_1 on every frame and nothing on the island reads it, so a load bit no callback of the map takes is no longer pending; the walk had never settled there.
• A hidden event's text row can sit past every object's, as the Mansion's four switches do, and the text table was grown before the hidden rows were read, so the switches opened nothing.
• PrintCardKeyText sets BIT_CUR_MAP_LOADED_1 behind the block, so the floor's callback flags the door on the next frame. The port flagged it on the next map load, and a second door opened elsewhere first overwrote wCardKeyDoorY: Silph Co. 3F's door shut again on the way back from 11F.
• A text_bcd over a buffer the script wrote every byte of is filled at import: Yellow's Safari gate printed <NUM_CD3D> where Red spells ¥500, and HiddenCoins' two boxes printed <NUM_FFA0> on all three cartridges.
• A trainer header's text can be machine code: Red's RocketHideoutB4FRocket3AfterBattleText, Lance's after-battle line and Yellow's end-battle text all decode as scripts now. The LIFT KEY had never appeared and EVENT_BEAT_LANCE had never been set.
• wBattleResult at zero had no outcome row, so the tower's MAROWAK stood again after every won fight.
• wSavedCoordIndex was written when a row was resolved rather than when its step was spent, so the Safari gate's "Leaving early?" asked for ever.
• OverworldLoop reads wCurOpponent after the script has returned, so a battle request now stands behind the rest of its row; Yellow's initial catch training set its event before the throw and the ball could miss.
• A Safari or tutorial battle keeps the back pic up and draws no player HUD; the Safari had been sending the lead out.
• A plain map text row and a trainer header's lines are filled from the run's buffers, so Lt. Surge's receipt names TM24 and the Silph rival names the player.
• Yellow's lab hands over the Pikachu and takes the parcel: wPartyMon1CatchRate is a silent store, DisablePikachuOverworldSpriteDrawing a silent call, and OaksLabScript_RemoveParcel's call reads like Red's jp.
• tools/validate.gd runs its topics from the first _process, since the root is not in the tree during _initialize.

Changed

• Cache format 132: Yellow's ProfOakPicBack is a third player_back slot, imported boxes carry their numbers, a hidden event's rows are read, and a state that calls EndTrainerBattle returns to the default one.
• The story tool answers elevator_requested, vending_requested, hall_of_fame_requested, quick_save_requested and soft_reset_requested, plans through spin tiles, surfs and lands, pushes a Generation 1 boulder the way TryPushingBoulder moves it, falls through a dungeon hole, takes a pad that lands on its own map as arriving, plans around a cell whose script moved the player off it, and names a crossing's edge cell.