Walk a Generation 1 routine's ret back into its caller and run Oak's Lab whole - #605
Merged
Conversation
…Lab whole A call to a map's own routine pushes a return frame on the walk's state, so a routine that branches walks the rest of the row on each side and its caller reads what each side computed; a jp to a named routine pushes none. With it: NPC_CHANGE_FACING held until the row writes the side over it, FillMemory over wNPCMovementDirections2 as a counted object walk, SetSpritePosition1 over nothing written as the restore it is, GetMonName over wRivalStarterTemp, cp n over a step count sampled at every step boundary, Yellow's $04 to $07 run rows, cp value under a CheckEitherEventSet mask, and the follower routines Yellow's lab and Bill's house call answered as no follower. hSpriteMapYCoord is the cell and four, which had placed Pewter's guides off by four. Every map-script body but the two link maps decodes on all three cartridges, and the walk drives the lab from Oak's speech to the rival leaving with the Pokedex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
gen1_walk.gddrives it on Red and Blue andtools/preview_world.gd -- red 0 40 <out.png> live lab_rival@5,6 20 0photographs the player turning to watch him go.callto a map's own routine pushes a return frame on the walk's state, so a routine that branches walks the rest of the row on each side; ajpto a named routine pushes none.NPC_CHANGE_FACINGis held until the row writes the side over it,FillMemoryoverwNPCMovementDirections2is a counted object walk,GetMonNamereads a scratch byte, andcp noverwSimulatedJoypadStatesIndexorwNPCNumScriptedStepsis a counted movement test the screen samples at every step boundary of a walk.$04to$07movement rows run atFunc_5288's doubled step,cp valueunder aCheckEitherEventSetmask is one flag set and one clear, and the Pikachu follower routines answer as no follower.Changed
wDoNotWaitForButtonPressAfterDisplayingTextlands on the row's last box wherever a routine printed it.Fixed
hSpriteMapYCoordisSPRITESTATEDATA2_MAPY, the cell and four: Pewter City's two guides and Bill were placed four cells off.SetSpritePosition1over nothing the row wrote is the restore ofGetSpritePosition1's save and no longer ends the walk.Gen1WorldImporter._script_node_exactshadowedObject.set.