Skip to content

Rename a Pokemon at the NAME RATER - #599

Merged
Decryptu merged 1 commit into
mainfrom
gen1-name-rater
Sep 8, 2026
Merged

Rename a Pokemon at the NAME RATER#599
Decryptu merged 1 commit into
mainfrom
gen1-name-rater

Conversation

@Decryptu

@Decryptu Decryptu commented Sep 8, 2026

Copy link
Copy Markdown
Owner

DisplayPartyMenu and DisplayNameRaterScreen are two decoded nodes whose carry is CANCEL, and what either answers decides the boxes behind it, so both sides ride the request unresolved and are walked once it has come back. NameRatersHouseCheckMonOTScript is read by its own address rather than walked, being a loop, and Gen2NameRater.matches_ot is the one test both generations compare an OT through. GetPartyMonName2 fills wNameBuffer and the keyboard's entry wBuffer, so each box names by its own address.

Gen2NamingScreen.for_gen1_mon is NAME_MON_SCREEN: ten underscores where the player's keyboard has seven, PrintNamingText's species name at hlcoord 4, 1 with NICKNAME? at hlcoord 1, 3, and WriteMonPartySpriteOAM's 2x2 icon at OAM ($10, $10). Gen1Layout.mon_icon_quadrant is the one place the symmetric writer's tile and flip are decided, which the party menu reads too.

Fixed

  • _map_script_successors read value off every set_map_script, and Yellow's wNextSafariZoneGateScript stores a byte it read back rather than a constant, so a Yellow import raised a runtime error and left that map's state reachability half built.
  • _prompt_icon sliced a tile strip by hand where Gen2PicImage.blit_tile reads it side by side; the naming screen's own icon shares that seam now.

Measurements

Red Blue Yellow
text_asm rows read 317 317 370
rows with an unknown arm 1 1 12, from 16

The one arm left on Red and Blue is unreachable: GateUpstairsScript_PrintIfFacingUp.up, which only a facing the jp nz already refused could take.

tools/checks/gen1_walk.gd renames a member, is answered .ATrulyImpeccableName for another trainer's, and is refused four ways: NO at either question, a list left with B, and an entry left blank. tools/checks/gen1_maps.gd pins the new census. Unit tier 3916/3916, full tier 4534/4534, validate.gd -- all clean on all six cartridges, replay_world.gd 33 routes 0 failures, the three-profile story walk clean, the analyser 0 warnings in 637 scripts.

tools/preview_world.gd -- red 0 229 <out.png> live name_rater@6,3 2 0 photographs the party list and 6 0 the keyboard.

`DisplayPartyMenu` and `DisplayNameRaterScreen` are two decoded nodes whose
carry is CANCEL, and what either answers decides the boxes behind it, so both
sides ride the request unresolved and are walked once it has come back.
`NameRatersHouseCheckMonOTScript` is read by its own address rather than walked,
being a loop, and `Gen2NameRater.matches_ot` is the one test both generations
compare an OT through. `GetPartyMonName2` fills `wNameBuffer` and the keyboard's
entry `wBuffer`, so each box names by its own address.

`Gen2NamingScreen.for_gen1_mon` is NAME_MON_SCREEN: ten underscores where the
player's keyboard has seven, `PrintNamingText`'s species name at `hlcoord 4, 1`
with NICKNAME? at `hlcoord 1, 3`, and `WriteMonPartySpriteOAM`'s 2x2 icon at OAM
($10, $10). `Gen1Layout.mon_icon_quadrant` is the one place the symmetric
writer's tile and flip are decided, which the party menu reads too.

Red and Blue read 317 `text_asm` rows with one unknown arm left, the unreachable
`GateUpstairsScript_PrintIfFacingUp.up`; Yellow goes from sixteen to twelve.

Two fixed on the way. `_map_script_successors` read `value` off every
`set_map_script`, and Yellow's `wNextSafariZoneGateScript` stores a byte it read
back rather than a constant, so a Yellow import raised a runtime error and left
that map's state reachability half built. And `_prompt_icon` sliced a tile strip
by hand where `Gen2PicImage.blit_tile` reads it side by side, which is the seam
the naming screen's own icon now shares.
@Decryptu
Decryptu merged commit 67688e1 into main Sep 8, 2026
1 check passed
@Decryptu
Decryptu deleted the gen1-name-rater branch September 8, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant