Rename a Pokemon at the NAME RATER - #599
Merged
Merged
Conversation
`DisplayPartyMenu` and `DisplayNameRaterScreen` are two decoded nodes whose carry is CANCEL, and what either answers decides the boxes behind it, so both sides ride the request unresolved and are walked once it has come back. `NameRatersHouseCheckMonOTScript` is read by its own address rather than walked, being a loop, and `Gen2NameRater.matches_ot` is the one test both generations compare an OT through. `GetPartyMonName2` fills `wNameBuffer` and the keyboard's entry `wBuffer`, so each box names by its own address. `Gen2NamingScreen.for_gen1_mon` is NAME_MON_SCREEN: ten underscores where the player's keyboard has seven, `PrintNamingText`'s species name at `hlcoord 4, 1` with NICKNAME? at `hlcoord 1, 3`, and `WriteMonPartySpriteOAM`'s 2x2 icon at OAM ($10, $10). `Gen1Layout.mon_icon_quadrant` is the one place the symmetric writer's tile and flip are decided, which the party menu reads too. Red and Blue read 317 `text_asm` rows with one unknown arm left, the unreachable `GateUpstairsScript_PrintIfFacingUp.up`; Yellow goes from sixteen to twelve. Two fixed on the way. `_map_script_successors` read `value` off every `set_map_script`, and Yellow's `wNextSafariZoneGateScript` stores a byte it read back rather than a constant, so a Yellow import raised a runtime error and left that map's state reachability half built. And `_prompt_icon` sliced a tile strip by hand where `Gen2PicImage.blit_tile` reads it side by side, which is the seam the naming screen's own icon now shares.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DisplayPartyMenuandDisplayNameRaterScreenare two decoded nodes whose carry is CANCEL, and what either answers decides the boxes behind it, so both sides ride the request unresolved and are walked once it has come back.NameRatersHouseCheckMonOTScriptis read by its own address rather than walked, being a loop, andGen2NameRater.matches_otis the one test both generations compare an OT through.GetPartyMonName2fillswNameBufferand the keyboard's entrywBuffer, so each box names by its own address.Gen2NamingScreen.for_gen1_monis NAME_MON_SCREEN: ten underscores where the player's keyboard has seven,PrintNamingText's species name athlcoord 4, 1with NICKNAME? athlcoord 1, 3, andWriteMonPartySpriteOAM's 2x2 icon at OAM ($10, $10).Gen1Layout.mon_icon_quadrantis the one place the symmetric writer's tile and flip are decided, which the party menu reads too.Fixed
_map_script_successorsreadvalueoff everyset_map_script, and Yellow'swNextSafariZoneGateScriptstores a byte it read back rather than a constant, so a Yellow import raised a runtime error and left that map's state reachability half built._prompt_iconsliced a tile strip by hand whereGen2PicImage.blit_tilereads it side by side; the naming screen's own icon shares that seam now.Measurements
text_asmrows readThe one arm left on Red and Blue is unreachable:
GateUpstairsScript_PrintIfFacingUp.up, which only a facing thejp nzalready refused could take.tools/checks/gen1_walk.gdrenames a member, is answered.ATrulyImpeccableNamefor another trainer's, and is refused four ways: NO at either question, a list left with B, and an entry left blank.tools/checks/gen1_maps.gdpins the new census. Unit tier 3916/3916, full tier 4534/4534,validate.gd -- allclean on all six cartridges,replay_world.gd33 routes 0 failures, the three-profile story walk clean, the analyser 0 warnings in 637 scripts.tools/preview_world.gd -- red 0 229 <out.png> live name_rater@6,3 2 0photographs the party list and6 0the keyboard.