Open the menus a Generation 1 row draws for itself - #597
Merged
Conversation
`TextBoxBorder`, `PlaceString` and `HandleMenuInput` are one seam. The `menu` node owns every step behind it the way a `YesNoChoice` does, so the tail is resolved once per row the box offers and once for the B press and the answer picks the walk that runs. Its rows are the fixed strings `PlaceString` placed, split on `<NEXT>`, or `wFilteredBagItems`, a `db` list `GetQuantityOfItemInBag` filters to what the bag holds. Three routines are read by the bytes they open with rather than by an address, each being a loop a walk cannot step through: `<Map>Script_Get*InBag`, `Print*InBag` and `OaksLabScript_RemoveParcel`. `wFossilItem` and `wFossilMon` ride the world snapshot, so the Cinnabar lab hands back the Pokemon the fossil it took on an earlier visit revives into, and `GetMonName` with `CopyToStringBuffer` behind it fills a box's two `text_ram` markers by address. `CeruleanBadgeHouseMiddleAgedManText`'s `SPECIALLISTMENU` is one node carrying its own loop: a chosen badge prints its line and the list reopens, and the `jr c` B answers is the way out. `predef DisplayDexRating` is `Gen2ProfOaksPC.rate`'s two pages, and `AnimateHealingMachine` sounds one `SFX_HEALING_MACHINE` per ball at `.partyLoop`'s `ld c, 30` with `MUSIC_PKMN_HEALED` behind them. Four things fixed beside them. `dec a` raised no Z, so `OaksAideScript`'s own `dec a ; jr nz` could not be read and Route 11 Gate 2F's aide said nothing. `ld h, d` refused a pair with no `hl` yet, which is a copy rather than a read. A store to `wOpponentAfterWrongAnswer` ended Cinnabar Gym's Blaine row. And `_gen1_written` matched `blackout_map` twice, so `SetLastBlackoutMap`'s own map never landed and the nurse's step answered for both. Every `text_asm` row on Red and Blue decodes now, 316 of them against 314, with five unknown branch arms against twelve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TextBoxBorder,PlaceStringandHandleMenuInputare one seam. Themenunode owns every step behind it the way aYesNoChoicedoes, so the tail is resolved once per row the box offers and once for the B press, and the answer picks the walk that runs. Its rows are the fixed stringsPlaceStringplaced, split on<NEXT>, orwFilteredBagItems, adblistGetQuantityOfItemInBagfilters to what the bag holds.Added
¥1000000beside them; the Cinnabar lab's fossil menu, whose choice is spent and whosewFossilMonthe next visit hands back as a Pokemon.CeruleanBadgeHouseMiddleAgedManText'sSPECIALLISTMENU: eight badges, a line each, the list reopening behind every one, and thejr cB answers as the way out.wFossilItemandwFossilMonride the world snapshot, andGetMonNamewithCopyToStringBufferbehind it fills a box's twotext_rammarkers by address.predef DisplayDexRating's two pages, and Route 11 Gate 2F's aide.AnimateHealingMachinesounds oneSFX_HEALING_MACHINEper ball at.partyLoop's ownld c, 30, withMUSIC_PKMN_HEALEDwhereFlashSprite8Timesopens.Fixed
dec araised no Z, soOaksAideScript's owndec a ; jr nzcould not be read and Route 11 Gate 2F's aide said nothing.ld h, drefused a pair with nohlwritten yet, which is a copy rather than a read.wOpponentAfterWrongAnswerended Cinnabar Gym's Blaine row._gen1_writtenmatchedblackout_maptwice, soSetLastBlackoutMap's own map never landed and the nurse's step answered for both.Changed
<Map>Script_Get*InBag,Print*InBagandOaksLabScript_RemoveParcel.text_asmrow on Red and Blue decodes now, 316 of them against 314, with five unknown branch arms against twelve.tools/checks/gen1_walk.gdtakes the drink menu with two of three drinks and is refused with none, lists two fossils and gets KABUTO back a visit later, reads one badge and finds the list reopened, and counts the heal machine's sounds.tools/preview_world.gd'sscript_menukind photographs any of the boxes.