fix(task): keep priority menu above task dialogs - #313
Open
WdBlink wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Change Scope
📝 What Does This PR Do?
Keeps the Task Creator and Task Editor priority menus above their modal backdrops by opting those two
CoveSelectinstances into the existingdialog-popoverlayer.This is intentionally local: the default
CoveSelectpopover layer and global z-index tokens remain unchanged. Regression coverage verifies both task-window call sites, confirms standalone selects retain the default layer, and exercises the Task Editor menu in Electron at a constrained viewport, including stacking, clipping, selection, and persistence.🏗️ Large Change Spec (Required if "Large Change" is checked)
Not applicable — this is a localized presentation-layer fix with no state, API, IPC, persistence, or lifecycle changes.
✅ Delivery & Compliance Checklist
pnpm pre-commitis completely green.CLA.md).DEVELOPMENT.mdarchitectural boundaries.Verification
urgent, and persists the value.pnpm build: passed.pnpm pre-commit: not completely green due to an unrelated upstream baseline failure. The changed Task Editor E2E passed in the full run. Final E2E summary: 262 passed, 47 skipped, 1 flaky, 1 failed.tests/e2e/workspace-canvas.agent-status-watcher.spec.ts—opens a non-focused project notification at the corresponding agentexpects viewport x/y movement greater than 30 but receives 0.upstream/mainand is outside this PR's five-file diff. A focused rerun reproduces the same failure.📸 Screenshots / Visual Evidence
Task Editor priority menu at a constrained 720×480 viewport; the complete menu remains visible above the dialog backdrop. The verified local screenshot is pending direct upload because no browser-control session was available during submission.