Skip to content

Fix masterportalapi defaults - #969

Open
warm-coolguy wants to merge 1 commit into
nextfrom
fix-masterportalapi-defaults
Open

Fix masterportalapi defaults#969
warm-coolguy wants to merge 1 commit into
nextfrom
fix-masterportalapi-defaults

Conversation

@warm-coolguy

@warm-coolguy warm-coolguy commented Sep 11, 2026

Copy link
Copy Markdown
Member

Summary

Somehow the default marker design from the masterportalAPI doesn't work at the moment. However, our docs say that we use the OL default anyway:

/**
* ID of the used style. If the layer is also configured in {@link MapConfiguration.markers | `mapConfiguration.markers`},
* that configuration takes precedence over the configured `styleId`. Only applicable for vector-type layers.
* For more information and an example see {@link MapConfiguration.featureStyles | `mapConfiguration.featureStyles`}.
* Defaults and fallbacks to OpenLayers default styling.
*/
styleId?: string

Hence, the OL default is now used, and markers will only appear if we configure them to.

Instructions for local reproduction and review

Remove markers entry in snowbox. Patch is in issue if you prefer that route. Run snowbox, receive styles.

Pull Request Checklist (for Assignee)

  • Functionality has been tested in Chrome

Relevant tickets, issues, et cetera

Resolves #959

@warm-coolguy warm-coolguy self-assigned this Sep 11, 2026
@warm-coolguy
warm-coolguy requested a review from a team September 11, 2026 11:43
@warm-coolguy warm-coolguy added the bug Something isn't working label Sep 11, 2026
@warm-coolguy
warm-coolguy changed the base branch from main to next September 11, 2026 11:43
@warm-coolguy
warm-coolguy force-pushed the fix-masterportalapi-defaults branch from 8d7628a to 6b6bbb3 Compare September 11, 2026 11:44
@warm-coolguy
warm-coolguy force-pushed the fix-masterportalapi-defaults branch from 6b6bbb3 to 53388bc Compare September 11, 2026 11:45
@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://Dataport.github.io/polar/pr-preview/pr-969/

Built to branch gh-pages at 2026-09-11 11:50 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invisible default design for point geometries

1 participant