Fix masterportalapi defaults - #969
Open
warm-coolguy wants to merge 1 commit into
Open
Conversation
warm-coolguy
requested review from
czirkelbach,
dopenguin,
oeninghe-dataport and
raschju
as code owners
September 11, 2026 11:43
warm-coolguy
force-pushed
the
fix-masterportalapi-defaults
branch
from
September 11, 2026 11:44
8d7628a to
6b6bbb3
Compare
warm-coolguy
force-pushed
the
fix-masterportalapi-defaults
branch
from
September 11, 2026 11:45
6b6bbb3 to
53388bc
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Somehow the default marker design from the masterportalAPI doesn't work at the moment. However, our docs say that we use the OL default anyway:
polar/src/core/types/layer.ts
Lines 121 to 127 in 22fd554
Hence, the OL default is now used, and markers will only appear if we configure them to.
Instructions for local reproduction and review
Remove
markersentry in snowbox. Patch is in issue if you prefer that route. Run snowbox, receive styles.Pull Request Checklist (for Assignee)
Relevant tickets, issues, et cetera
Resolves #959