Skip to content

Fix panic when call cleanupMap twice #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 1 commit into from
Sep 7, 2026
+8 −0
Merged

Fix panic when call cleanupMap twice #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions perfmap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,10 @@ func (m *PerfMap) closeReader() error {
func (m *PerfMap) cleanupMap(cleanup MapCleanupType) error {
m.stateLock.Lock()
defer m.stateLock.Unlock()
// check if map was already closed
if m.state == reset {
return nil
}
return m.close(cleanup)
}

Expand Down
4 changes: 4 additions & 0 deletions ringbuffer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,10 @@ func (rb *RingBuffer) closeReader() error {
func (rb *RingBuffer) cleanupMap(cleanup MapCleanupType) error {
rb.stateLock.Lock()
defer rb.stateLock.Unlock()
// check if map was already closed
if rb.state == reset {
return nil
}
return rb.close(cleanup)
}

Expand Down
Loading