add state to socketLink to prevent errors - #286
Merged
Conversation
If you called Pause() then Close(), it would result in an error
mbertrone
reviewed
Sep 2, 2026
| if errors.Is(err, unix.ENOENT) { | ||
| s.attached = false | ||
| } | ||
| return err |
Contributor
There was a problem hiding this comment.
suggestion (non-blocking): the ENOENT branch reconciles state to attached=false but still returns the error, so an already-detached socket surfaces a spurious error through Close()/Pause() into the joined result at probe.go:703. Not a regression, and only reachable when kernel and tracked state diverge, but returning the error here works against the idempotent-detach intent of this PR. If that divergence is the expected "already detached" case, return nil after clearing the flag:
if errors.Is(err, unix.ENOENT) {
s.attached = false
return nil
}
return err
Member
Author
There was a problem hiding this comment.
I think surfacing the error when kernel and tracked state diverge is important
mbertrone
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
attachedstate tosocketLinkMotivation
If you called
Pause()thenClose(), it would result in an errorAdditional Notes
Describe how to test your changes