Expand framework and platform compatibility coverage - #126
Conversation
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 1e81b6a | Docs | View more details | Give us feedback! |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Vitest 1 discovery now removes the first custom command option. A command that starts with --config can select the wrong files or no files.
🤖 Datadog Autotest · Commit a496890 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
|
@autotest review |
There was a problem hiding this comment.
More details
The Mocha code supports both module layouts. The Vitest and Python changes match the new compatibility limits.
🤖 Datadog Autotest · Commit 1e81b6a · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
E2E Test Report: SUCCESS ✅Tested by: Shepherd Agent (autonomous QA for Datadog Test Optimization) Test Environment
Results
Issues Found
No PR-specific blocker was found. Verification
Test Methodology
This E2E test was performed by Shepherd - autonomous QA agent for Datadog Test Optimization |
What
parseCLIAPI and serializing empty CLI arguments as[]. This prevents discovery from silently falling back to a generic filesystem glob and selecting the wrong test files..jsCLI modules used by Mocha 8–11 and the renamed.cjsmodules used by Mocha 12.ddtrace>=4.11.0requirement; 4.10.3 does not implement the discovery-mode environment contract DDTest uses.internal/compatibilitypackage with separate files per platform/framework, and expand CI across minimum, latest, and framework-specific boundary versions.Why
The expanded end-to-end matrix exposed existing compatibility failures rather than test-only issues. Vitest 1.6's fallback could ignore project configuration and return the wrong file set, while Mocha 12 could not load the adapter after its private CLI modules changed extension. The Python implementation also still accepted ddtrace 4.10.3 even though the documented minimum and required discovery protocol begin at 4.11.0.
Keeping these fixes with the compatibility tests makes the advertised support boundaries executable and prevents Test Impact Analysis from planning or skipping the wrong tests.
E2E testing
make testand confirm all unit and integration packages pass.make lintand confirm the repository reports no issues.--configfile and confirm discovery returns both configured files while execution runs only the selected file.