chore(ci): refresh 3.15 riot lockfiles for crashtracker and grpc by vlad-scherbich · Pull Request #20002 · DataDog/dd-trace-py

vlad-scherbich · 2026-09-01T21:14:09Z

Description

Delta vs #19270. Riot hash-renamed the 3.15 crashtracker and grpc lockfiles (95077af → 128e1e1, 222bcd0 → 1857594) and dropped two stale profile lockfiles. supported_versions.json records grpcio 1.83.1 as tested on 3.15.

If this merges and nothing else new lands: check_requirements_lockfiles matches the #19270 riotfile. Collectors, native, and IMAGE_TAG are unchanged.

Testing

check_requirements_lockfiles on this head.

Risks

None.

Additional Notes

Base: #19270 (vlad/ddtracepy-315-profiling-collectors). Independent of the IMAGE_TAG rebuild. No release note: CI chore, changelog/no-changelog.

# Conflicts: # ddtrace/internal/monitoring.py # ddtrace/internal/wrapping/asyncs.py

Profiling-native py3.15 job, setup.py guards, and crashtracker 3.15 opt-in. Rebased onto the #17849 split stack (PR 17624). # Conflicts: # riotfile.py # setup.py

The collectors PR already claimed setup.py could build natives on 3.15, but rust profiling, libdd_wrapper, and memalloc/ddup/stack were still skipped below 3.15. Lift those bounds to match the Cython modules. Also stop attributing current_task() RuntimeError to 3.15.

The crashtracker 3.15 lockfile shipped rebase markers that block landing.

Two extra blank lines failed ruff format --check in CI.

Riot hash-renamed the 3.15 crashtracker and grpc lockfiles; drop stale profile lockfiles and record grpcio 1.83.1 as tested on 3.15.

cit-pr-commenter-54b7da · 2026-09-01T21:15:08Z

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

cit-pr-commenter-54b7da · 2026-09-01T21:15:11Z

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 240 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 240 highest severity)

ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=135)
ddtrace.internal.ci_visibility.api._base -×-> ddtrace.trace  (product:ci_visibility -> product:tracing, score=133)
ddtrace.llmobs._integrations.litellm -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.llmobs._integrations.vertexai -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.llmobs._integrations.langgraph -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:
uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

cit-pr-commenter-54b7da · 2026-09-01T21:15:18Z

Codeowners resolved as

Resolved from the full PR diff against vlad/ddtracepy-315-profiling-collectors using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

.riot/requirements/128e1e1.txt                                          @DataDog/apm-python
.riot/requirements/1857594.txt                                          @DataDog/apm-python
supported_versions.json                                                 @DataDog/apm-core-python @DataDog/apm-idm-python

datadog-prod-us1-6 · 2026-09-01T21:15:50Z

✨ Unblock PR with BitsAI

⚠️ Warnings

❌ Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 24 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | check_requirements_lockfiles — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-py | contrib/logging 1/1 — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-py | profiling/profile 18/23 — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

View all 24 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: ac94415 | Docs | View more details | Give us feedback!}

vlad-scherbich · 2026-09-01T21:31:10Z

Closing: leftover from the #19270 split.

Crashtracker 3.15 lock is on ci(profiling): opt crashtracker riot into Python 3.15 #20007
grpc 3.15 schedule + lock is on ci(riot): schedule grpc on Python 3.15 #20004 (child of ci(riot): schedule Python 3.15 jobs for 'smoke_test.py ' (PROF-14439) #19906)
Orphan profile-shaped 3.15 locks are dropped (profile riot pys is still 3.14)

pr-commenter · 2026-09-01T21:45:44Z

Benchmarks

Benchmark execution time: 2026-09-01 21:45:40

Comparing candidate commit ac94415 in PR branch vlad/19270-riot-lockfile-refresh with baseline commit 3e2ed19 in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 7 performance regressions! Performance is the same for 579 metrics, 10 unstable metrics, 1 known flaky benchmarks, 17 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:httppropagationinject-ids_only

🟥 execution_time [+2.529µs; +2.709µs] or [+15.284%; +16.377%]

scenario:iastaspects-add_aspect

🟥 execution_time [+7.683µs; +10.205µs] or [+7.741%; +10.282%]

scenario:iastaspects-repr_aspect

🟥 execution_time [+78.836µs; +86.181µs] or [+21.990%; +24.039%]

scenario:iastaspectsospath-ospathbasename_aspect

🟥 execution_time [+127.031µs; +132.615µs] or [+32.524%; +33.954%]

scenario:iastaspectssplit-rsplit_aspect

🟥 execution_time [+25.831µs; +30.432µs] or [+18.596%; +21.908%]

scenario:telemetryaddmetric-1-count-metric-1-times

🟥 execution_time [+644.223ns; +681.092ns] or [+23.803%; +25.165%]

scenario:tracer-small

🟥 execution_time [+27.232µs; +29.489µs] or [+8.103%; +8.774%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:coreapiscenario-context_with_data_listeners

unstable execution_time [-704.411ns; +781.485ns] or [-6.444%; +7.150%]

scenario:coreapiscenario-core_dispatch_1_listener

unstable execution_time [-34.354ns; +31.587ns] or [-5.617%; +5.165%]

scenario:coreapiscenario-core_dispatch_50_listeners

unstable execution_time [-1418.697ns; +1860.572ns] or [-8.435%; +11.062%]

scenario:coreapiscenario-core_dispatch_exception_listeners

unstable execution_time [-999.619ns; +1473.688ns] or [-7.781%; +11.471%]

scenario:coreapiscenario-core_dispatch_listeners

unstable execution_time [-260.434ns; +385.247ns] or [-7.197%; +10.646%]

scenario:coreapiscenario-core_dispatch_no_args_listeners

unstable execution_time [-185.867ns; +320.847ns] or [-6.472%; +11.172%]

scenario:coreapiscenario-core_dispatch_with_results_1_listener

unstable execution_time [-63.554ns; +87.880ns] or [-5.396%; +7.461%]

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

unstable execution_time [-4023.640ns; +3921.647ns] or [-9.903%; +9.652%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

unstable execution_time [-780.581ns; +781.849ns] or [-9.598%; +9.613%]

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

unstable execution_time [-59349.129ns; +58779.694ns] or [-9.498%; +9.406%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:iastaspects-title_noaspect

🟥 execution_time [+29.981µs; +37.257µs] or [+15.528%; +19.296%]

Known flaky benchmarks without significant changes:

scenario:errortrackingflasksqli-baseline
scenario:flasksimple-iast-get
scenario:iastaspects-casefold_aspect
scenario:iastaspects-casefold_noaspect
scenario:iastaspects-index_aspect
scenario:iastaspects-ljust_noaspect
scenario:iastaspects-lower_aspect
scenario:iastaspects-replace_aspect
scenario:iastaspects-swapcase_aspect
scenario:iastaspects-translate_aspect
scenario:iastaspects-translate_noaspect
scenario:iastaspects-upper_noaspect
scenario:packagespackageforrootmodulemapping-cache_off
scenario:packagespackageforrootmodulemapping-cache_on
scenario:sethttpmeta-all-enabled
scenario:span-start
scenario:telemetryaddmetric-record-100-metrics

vlad-scherbich added 8 commits August 31, 2026 22:33

chore(profiling): update Python profiling collectors for py3.15

9dc545a

# Conflicts: # ddtrace/internal/monitoring.py # ddtrace/internal/wrapping/asyncs.py

typing: annotate profiling collectors for py3.15

704153b

ci(profiling): wire py3.15 into build matrix, riotfile, and CI

192d18b

Profiling-native py3.15 job, setup.py guards, and crashtracker 3.15 opt-in. Rebased onto the #17849 split stack (PR 17624). # Conflicts: # riotfile.py # setup.py

fix(ci): drop committed conflict markers from riot lockfile 222bcd0

90ec053

The crashtracker 3.15 lockfile shipped rebase markers that block landing.

style(profiling): ruff-format monitoring.py

b61b85c

Two extra blank lines failed ruff format --check in CI.

fix(profiling): make ImportError collector stubs constructible

da3df55

chore(ci): refresh 3.15 riot lockfiles for crashtracker and grpc

ac94415

Riot hash-renamed the 3.15 crashtracker and grpc lockfiles; drop stale profile lockfiles and record grpcio 1.83.1 as tested on 3.15.

vlad-scherbich added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 1, 2026

vlad-scherbich force-pushed the vlad/ddtracepy-315-profiling-collectors branch from da3df55 to 989dea6 Compare September 1, 2026 21:29

vlad-scherbich mentioned this pull request Sep 1, 2026

ci(profiling): opt crashtracker riot into Python 3.15 #20007

Closed

vlad-scherbich closed this Sep 1, 2026

Uh oh!

Conversation

vlad-scherbich commented Sep 1, 2026

Description

Testing

Risks

Additional Notes

Uh oh!

cit-pr-commenter-54b7da Bot commented Sep 1, 2026

Circular import analysis

⚠️ Existing circular imports

Uh oh!

cit-pr-commenter-54b7da Bot commented Sep 1, 2026

Dependency direction analysis

⚠️ Existing dependency direction violations

Uh oh!

cit-pr-commenter-54b7da Bot commented Sep 1, 2026

Codeowners resolved as

Uh oh!

datadog-prod-us1-6 Bot commented Sep 1, 2026 • edited by datadog-prod-us1-4 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

vlad-scherbich commented Sep 1, 2026

Uh oh!

pr-commenter Bot commented Sep 1, 2026

Benchmarks

Explanation

More details about the CI and significant changes

scenario:httppropagationinject-ids_only

scenario:iastaspects-add_aspect

scenario:iastaspects-repr_aspect

scenario:iastaspectsospath-ospathbasename_aspect

scenario:iastaspectssplit-rsplit_aspect

scenario:telemetryaddmetric-1-count-metric-1-times

scenario:tracer-small

Unstable benchmarks

scenario:coreapiscenario-context_with_data_listeners

scenario:coreapiscenario-core_dispatch_1_listener

scenario:coreapiscenario-core_dispatch_50_listeners

scenario:coreapiscenario-core_dispatch_exception_listeners

scenario:coreapiscenario-core_dispatch_listeners

scenario:coreapiscenario-core_dispatch_no_args_listeners

scenario:coreapiscenario-core_dispatch_with_results_1_listener

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

scenario:coreapiscenario-core_dispatch_with_results_listeners

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

Known flaky benchmarks

scenario:iastaspects-title_noaspect

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

datadog-prod-us1-6 Bot commented Sep 1, 2026 •

edited by datadog-prod-us1-4 Bot

Loading