Skip to content

Vlad/profiling native test install subdir #19257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vlad-scherbich merged 1 commit into from
Jul 24, 2026
Merged

Vlad/profiling native test install subdir #19257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions ddtrace/internal/datadog/profiling/stack/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,12 @@ if(DO_VALGRIND)
endif()

function(dd_wrapper_add_test name)
add_executable(${name} ${ARGN})
# Optional keyword argument: INSTALL_SUBDIR <dir> Installs the test binary to test/<dir>/ instead of test/. Use for
# version-specific binaries (e.g. INSTALL_SUBDIR py315) to prevent CI artifact collisions when build_base_venvs runs
# in parallel across Python versions and GitLab merges all artifacts into a shared directory.
cmake_parse_arguments(_ARG "" "INSTALL_SUBDIR" "" ${ARGN})
set(_SOURCES ${_ARG_UNPARSED_ARGUMENTS})
add_executable(${name} ${_SOURCES})
target_include_directories(${name} PRIVATE ../include)
# this has to refer to the stack extension name to properly link against
target_link_libraries(${name} PRIVATE gmock gtest_main ${EXTENSION_NAME})
Expand Down Expand Up @@ -72,7 +77,11 @@ function(dd_wrapper_add_test name)
endif()

if(LIB_INSTALL_DIR)
install(TARGETS ${name} RUNTIME DESTINATION ${LIB_INSTALL_DIR}/../test)
if(_ARG_INSTALL_SUBDIR)
install(TARGETS ${name} RUNTIME DESTINATION ${LIB_INSTALL_DIR}/../test/${_ARG_INSTALL_SUBDIR})
else()
install(TARGETS ${name} RUNTIME DESTINATION ${LIB_INSTALL_DIR}/../test)
endif()
endif()
endfunction()

Expand Down
Loading