Skip to content

fix: bump ZAI_CONFIG_ENTRIES_COUNT_MAX to 400#4059

Closed
MilanGarnier wants to merge 1 commit into
masterfrom
milan.garnier/bump-zai-config-entries-max
Closed

fix: bump ZAI_CONFIG_ENTRIES_COUNT_MAX to 400#4059
MilanGarnier wants to merge 1 commit into
masterfrom
milan.garnier/bump-zai-config-entries-max

Conversation

@MilanGarnier

@MilanGarnier MilanGarnier commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Why

Master has been unable to publish a dev build since #3997 merged. That PR
added the DD_TRACE_PROPAGATION_BEHAVIOR_EXTRACT config plus new
per-integration entries, pushing the total number of registered config
entries to ~302 - over the compile-time cap of 300 in
ZAI_CONFIG_ENTRIES_COUNT_MAX.

This trips the static assert in ext/configuration.c:

#define NUMBER_OF_CONFIGURATIONS sizeof((uint8_t[]){DD_ALL_CONFIGURATIONS})
_Static_assert(NUMBER_OF_CONFIGURATIONS < ZAI_CONFIG_ENTRIES_COUNT_MAX,
               "There are more config entries than ZAI_CONFIG_ENTRIES_COUNT_MAX.");

which breaks the compile tracing extension jobs

Fix

Bump ZAI_CONFIG_ENTRIES_COUNT_MAX from 300 to 400 to restore extra
capacity above the current count (~302) for new config entries.

PR #3997 pushed the real config entry count (~302, incl. per-integration
ANALYTICS_ENABLED/ANALYTICS_SAMPLE_RATE aliases) past the compile-time
cap of 300, tripping the static assert in ext/configuration.c and
breaking every master build since, which also blocked the
publish-to-s3 dev release job.
@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Jul 24, 2026

Copy link
Copy Markdown

Pipelines  Tests

Unblock PR with BitsAI

⚠️ Warnings

🚦 43 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | PHP Language Tests: [7.1]   View in Datadog   GitLab

🧪 2 Tests failed

All test failures are known flaky.

❄️ Known flaky: opendir-003.phpt - opendir() with &#39;ftps://&#39; stream. from php-src.php-src.ext.standard.tests.streams   View in Datadog
002&#43; error:0A000086:SSL routines::certificate verify failed in /usr/local/src/php/ext/standard/tests/streams/opendir-003.php on line 10
003&#43; 
002-  in %s on line %d
007&#43; 
009&#43; error:0A000415:SSL routines::sslv3 alert certificate expired in /usr/local/src/php/ext/ftp/tests/server.inc on line 121
010&#43; SSLv23 handshake failed.

Not introduced in this PR.

❄️ Known flaky: opendir-004.phpt - opendir() with &#39;ftps://&#39; stream. from php-src.php-src.ext.standard.tests.streams   View in Datadog
002&#43; error:0A000086:SSL routines::certificate verify failed in /usr/local/src/php/ext/standard/tests/streams/opendir-004.php on line 10
003&#43; 
005&#43; bool(false)
006&#43; 
001- resource(%d) of type (stream)
002- string(5) &#34;file1&#34;
003- string(5) &#34;file1&#34;
004- string(3) &#34;fil&#34;
005- string(4) &#34;b0rk&#34;
009&#43; 
...

Not introduced in this PR.

DataDog/apm-reliability/dd-trace-php | PHP Language Tests: [7.3]   View in Datadog   GitLab

🧪 1 Test failed

All test failures are known flaky.

❄️ Known flaky: opendir() with &#39;ftps://&#39; stream. from PHP.ext.standard.tests.streams   View in Datadog
002&#43; error:0A000086:SSL routines::certificate verify failed in /usr/local/src/php/ext/standard/tests/streams/opendir-004.php on line 10
003&#43; 
005&#43; bool(false)
006&#43; 
001- resource(%d) of type (stream)
002- string(5) &#34;file1&#34;
003- string(5) &#34;file1&#34;
004- string(3) &#34;fil&#34;
005- string(4) &#34;b0rk&#34;
009&#43; 
...

Not introduced in this PR.

DataDog/apm-reliability/dd-trace-php | PHP Language Tests: [8.0]   View in Datadog   GitLab

🧪 2 Tests failed

All test failures are known flaky.

❄️ Known flaky: ext/standard/tests/streams/opendir-003.phpt (opendir() with &#39;ftps://&#39; stream.) from PHP.ext.standard.tests.streams   View in Datadog
002&#43; error:0A000086:SSL routines::certificate verify failed in /usr/local/src/php/ext/standard/tests/streams/opendir-003.php on line 10
003&#43; 
005&#43; error:0A000415:SSL routines::sslv3 alert certificate expired in /usr/local/src/php/ext/ftp/tests/server.inc on line 115
006&#43; SSLv23 handshake failed.
007&#43; 
002-  in %s on line %d
     bool(false)

Not introduced in this PR.

❄️ Known flaky: ext/standard/tests/streams/opendir-004.phpt (opendir() with &#39;ftps://&#39; stream.) from PHP.ext.standard.tests.streams   View in Datadog
002&#43; error:0A000415:SSL routines::sslv3 alert certificate expired in /usr/local/src/php/ext/ftp/tests/server.inc on line 115
003&#43; SSLv23 handshake failed.
004&#43; 
001- resource(%d) of type (stream)
002- string(5) &#34;file1&#34;
003- string(5) &#34;file1&#34;
004- string(3) &#34;fil&#34;
005- string(4) &#34;b0rk&#34;
006&#43; error:0A000086:SSL routines::certificate verify failed in /usr/local/src/php/ext/standard/tests/streams/opendir-004.php on line 10
007&#43; 
...

Not introduced in this PR.

View all 43 failed jobs.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.65% (+9.17%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 670a0d8 | Docs | Datadog PR Page | Give us feedback!

@MilanGarnier
MilanGarnier marked this pull request as ready for review July 24, 2026 09:52
@MilanGarnier
MilanGarnier requested a review from a team as a code owner July 24, 2026 09:52
@realFlowControl

Copy link
Copy Markdown
Member

This looks like it is solving the same issue as #4057

@MilanGarnier

Copy link
Copy Markdown
Contributor Author

Thanks I had missed it, I'm closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants