build(deps): bump tests/FeatureFlags/ffe-system-test-data from 4446371 to f3da9ae#4058
Conversation
Bumps [tests/FeatureFlags/ffe-system-test-data](https://github.com/DataDog/ffe-system-test-data) from `4446371` to `f3da9ae`. - [Commits](DataDog/ffe-system-test-data@4446371...f3da9ae) --- updated-dependencies: - dependency-name: tests/FeatureFlags/ffe-system-test-data dependency-version: f3da9ae56b4dd765a46de64482c6904e2c67ffb2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03f17b2d58
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1 +1 @@ | |||
| Subproject commit 4446371bc1ca52bd526356927ef42d380145b118 | |||
| Subproject commit f3da9ae56b4dd765a46de64482c6904e2c67ffb2 | |||
There was a problem hiding this comment.
This data bump changes expected result.reason values in the date fixtures and adds result.errorCode expectations for test-flag-that-does-not-exist.json, but the in-repo fixture sweep only checks result.value in tests/ext/ffe/system_test_data_evaluate.phpt:154-163. If the PHP evaluator keeps returning the old reason (for example STATIC instead of DEFAULT) or omits FLAG_NOT_FOUND, CI will still report failures=0, so this submodule update does not actually validate the new canonical semantics; please extend the sweep to assert reason and errorCode when present before accepting the bump.
Useful? React with 👍 / 👎.
| @@ -1 +1 @@ | |||
| Subproject commit 4446371bc1ca52bd526356927ef42d380145b118 | |||
| Subproject commit f3da9ae56b4dd765a46de64482c6904e2c67ffb2 | |||
There was a problem hiding this comment.
This bump adds malformed/unsupported flag cases whose expected result is the caller default with reason: DEFAULT, but the current bridge maps FlagConfigurationInvalid to ERROR_CONFIG_PARSE in components-rs/ffe.rs:230-231, and ResultMapper turns any non-zero bridge error into an EvaluationReason::ERROR detail in src/api/FeatureFlags/Internal/ResultMapper.php:57-67. In environments that run these new *-isolation.json fixtures with reason/error assertions, evaluating flags such as malformed-allocations-flag, operator-grease-flag, or the invalid shard-bound flags will report a parse error instead of the fixture's default result, so the fixture bump should be paired with the evaluator/bridge change that treats per-flag parse failures as ignored defaults.
Useful? React with 👍 / 👎.
Bumps tests/FeatureFlags/ffe-system-test-data from
4446371tof3da9ae.Commits
f3da9aeMerge pull request #18 from DataDog/leo.romanovsky/revert-regex-shard-bound-f...44092cefix: limit rollback to regex fixtures9864c01fix: restore static temporal allocation reasonscb09e08revert: remove regex and shard-bound fixturesa596df7Merge pull request #17 from DataDog/leo.romanovsky/regex-shard-bound-fixturesce45493Add regex and shard-bound fixtures6c7f63bMerge pull request #16 from DataDog/leo.romanovsky/malformed-split-shards-fix...cf7d7d5Add missing split shards fixtured9d8020Merge pull request #15 from DataDog/leo.romanovsky/date-window-assignment-rea...e4803e3Fix temporal allocation reasonsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)