Add instrumented test to Datadog modifier against recomposition - #3668
Add instrumented test to Datadog modifier against recomposition#3668ambushwork wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3668 +/- ##
===========================================
- Coverage 73.35% 73.27% -0.07%
===========================================
Files 995 995
Lines 36332 36332
Branches 6141 6141
===========================================
- Hits 26648 26622 -26
- Misses 7977 7995 +18
- Partials 1707 1715 +8 🚀 New features to boost your workflow:
|
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b67146c9da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b67146c to
eefec9c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eefec9c0bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
eefec9c to
a02855c
Compare
| // Required for the Compose compiler plugin (needed by the Compose instrumented tests below) | ||
| // to find the runtime it targets when compiling the main source set. | ||
| compileOnly(platform(libs.androidXComposeBom)) | ||
| compileOnly(libs.androidXComposeRuntime) |
There was a problem hiding this comment.
I don't think this is right. The only place where Compose is used is in the androidTest set, not main. So probably you want it there only?
There was a problem hiding this comment.
Well, this can't be removed neither, the compiler throws the error when they are absent:
androidx.compose.compiler.plugins.kotlin.IncompatibleComposeRuntimeVersionException: The Compose Compiler requires the Compose Runtime to be on the class path, but none could be found. The compose compiler plugin you are using (version 1.5.14) expects a minimum runtime version of 1.0.0.
| debugImplementation(platform(libs.androidXComposeBom)) | ||
| debugImplementation(libs.androidXComposeUiTestManifest) |
There was a problem hiding this comment.
Shouldn't it be just androidTestImplementation for both? Why do we put debug and add them for the main set?
There was a problem hiding this comment.
This is because androidx.compose.ui:ui-test-manifest module must be set in debug classpath, here is the example from Android doc, comments says that " Needed for createComposeRule()".
a02855c to
54a1bce
Compare
54a1bce to
d5c0e4f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5c0e4fb0a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3 participants
What does this PR do?
This PR adds an instrumented test to protect the fix against the regression, it is inspired by the reproduce repo from this issue.
Review checklist (to be filled by reviewers)