RUM-16379: Fix dialog opening from another dialog in sr - #3563
RUM-16379: Fix dialog opening from another dialog in sr#3563jonathanmos wants to merge 6 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
fb1d870 to
3fa1209
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #3563 +/- ##
===========================================
+ Coverage 73.29% 73.37% +0.08%
===========================================
Files 995 996 +1
Lines 36297 36398 +101
Branches 6136 6151 +15
===========================================
+ Hits 26601 26704 +103
+ Misses 7986 7983 -3
- Partials 1710 1711 +1
🚀 New features to boost your workflow:
|
15d2c3d to
17a292a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17a292a2c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
17a292a to
ff21e5a
Compare
daf3d39 to
d2f3469
Compare
d2f3469 to
0b0bcf3
Compare
af6e7c6 to
1964127
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 19641270bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44139c2658
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
44139c2 to
ce00228
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce00228bf1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ce00228 to
cb5fc57
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb5fc57a8a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (shouldRecord) { | ||
| val decorViews = windowInspector.getGlobalWindowViews(internalLogger) | ||
| windowCallbackInterceptor.intercept(windows, appContext) | ||
| windowCallbackInterceptor.intercept(windows + resolveUntrackedWindows(decorViews, windows), appContext) |
There was a problem hiding this comment.
Keep paused windows excluded during lifecycle intercepts
When activity A pauses but its decor remains in the global roots and activity B then resumes, windows contains only B, so resolveUntrackedWindows(decorViews, windows) classifies A as untracked and passes it back to intercept(). That method removes every supplied window from excludedWindows and wraps it, undoing the paused-window protection. The fresh evidence beyond the previously addressed dynamic-scan issue is this lifecycle path bypassing the exclusion predicate; resolve against all currently active lifecycle windows or preserve exclusions when adding discovered dialogs.
Useful? React with 👍 / 👎.
What does this PR do?
Fixes an issue recording dialogs opened from within other dialogs in session replay. This pr also includes a couple of other small fixes:
• Fixes a crash in the fine grained masking screen in the sample application
• Guard against NaN fontsize by providing a default fallback value.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)