Skip to content

[CWS] Account for two expected ways a TC classifier attachment can fail - #55835

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
yoanngh/netns-tc-error-classes
Sep 3, 2026
Merged

[CWS] Account for two expected ways a TC classifier attachment can fail#55835
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
yoanngh/netns-tc-error-classes

Conversation

@YoannGh

@YoannGh YoannGh commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Accounts for two failures of the network namespace resolver that were reported as unclassified.

Motivation

Container runtimes move network interfaces to the network namespace of the container as soon as they create them, so errors such as "no such device" or "filter not found" midway into attaching new TC filters are expected.

Since interfaces are tracked by the dev_change_net_namespace hook, the TC filter attachments are retried after the interface move is done.

Describe how you validated your changes

Unit test on the error classification.

Additional Notes

The ebpf-manager dependency bump brings in this change and allows properly classifying "no such device" errors occurring when an interface is moved from one network namespace to another.

Attaching a classifier to an interface runs through several steps, and
the interface can be handed over to the network namespace of a container
at any point along the way. The steps that were left unaccounted for are
the two last ones: the filter being added, and the filter being read back
to confirm it.

Losing the interface during the first one is reported as a missing
device, which the eBPF manager now describes precisely enough to be
recognised on its own. Losing it during the second one leaves the filter
nowhere to be found, and gets a class of its own so that a rise without
any missing device stays visible, since that would mean the filter is
there but goes unrecognised rather than the interface being gone.
@YoannGh
YoannGh requested a review from a team as a code owner September 3, 2026 14:49
@YoannGh YoannGh added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests labels Sep 3, 2026
@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/agent-security labels Sep 3, 2026
@github-actions github-actions Bot added the medium review PR review might take time label Sep 3, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review by Codex (OpenAI) - workflow run

Patch is incorrect: the new text-based classification is broader than the documented upstream error shape and can suppress unrelated failures.

Comment thread pkg/security/resolvers/netns/errors.go
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 55.24% (+0.03%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 11f9fdf | Docs | View more details | Give us feedback!

@YoannGh YoannGh changed the title [CWS] Count the last two ways a classifier fails to attach [CWS] Account for two expected ways a classifier attachment can fail Sep 3, 2026
@YoannGh YoannGh changed the title [CWS] Account for two expected ways a classifier attachment can fail [CWS] Account for two expected ways a TC classifier attachment can fail Sep 3, 2026
@dd-octo-sts

dd-octo-sts Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 7487046a:

Results for datadog-agent_7.84.0~devel.git.758.11f9fdf.pipeline.135229635-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.84.0~devel.git.758.11f9fdf.pipeline.135229635-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 7487046
📊 Static Quality Gates Dashboard
🔗 SQG Job

33 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 760.821 MiB
agent_deb_amd64_fips 713.031 MiB
agent_heroku_amd64 316.053 MiB
agent_msi 647.755 MiB
agent_rpm_amd64 760.804 MiB
agent_rpm_amd64_fips 713.015 MiB
agent_rpm_arm64 734.027 MiB
agent_rpm_arm64_fips 689.626 MiB
agent_suse_amd64 760.804 MiB
agent_suse_amd64_fips 713.015 MiB
agent_suse_arm64 734.027 MiB
agent_suse_arm64_fips 689.626 MiB
docker_agent_amd64 819.782 MiB
docker_agent_arm64 818.061 MiB
docker_agent_jmx_amd64 1010.695 MiB
docker_agent_jmx_arm64 997.753 MiB
docker_cluster_agent_amd64 212.643 MiB
docker_cluster_agent_arm64 225.718 MiB
docker_cws_instrumentation_amd64 7.439 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.550 MiB
docker_dogstatsd_arm64 37.623 MiB
docker_host_profiler_amd64 307.569 MiB
docker_host_profiler_arm64 318.787 MiB
dogstatsd_deb_amd64 30.291 MiB
dogstatsd_deb_arm64 28.303 MiB
dogstatsd_rpm_amd64 30.291 MiB
dogstatsd_suse_amd64 30.291 MiB
iot_agent_deb_amd64 46.588 MiB
iot_agent_deb_arm64 43.221 MiB
iot_agent_deb_armhf 44.031 MiB
iot_agent_rpm_amd64 46.589 MiB
iot_agent_suse_amd64 46.588 MiB

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 3, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: 8233e604-6322-45d0-8b6f-5c32396050c6

Baseline: a13111c
Comparison: d851389
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +3.09 [+2.24, +3.95] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization +0.80 [+0.75, +0.84] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization +0.59 [+0.37, +0.82] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization +0.17 [+0.05, +0.30] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.15 [+0.12, +0.18] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization +0.04 [-0.04, +0.11] 1 Logs bounds checks dashboard
dsd_uds_10mb_3k_timestamped_contexts_cpu % cpu utilization -0.01 [-0.26, +0.23] 1 Logs
quality_gate_idle memory utilization -0.03 [-0.07, +0.02] 1 Logs bounds checks dashboard
dsd_uds_10mb_3k_timestamped_contexts_memory memory utilization -0.03 [-0.24, +0.17] 1 Logs
quality_gate_idle_all_features memory utilization -0.59 [-0.63, -0.55] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 4 ≤ 5 bounds checks dashboard
quality_gate_idle memory_usage 10/10 174.05MiB ≤ 179MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 745.20KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 4 ≤ 5 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 517.30MiB ≤ 537MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.13MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 18 ≤ 40 bounds checks dashboard
quality_gate_logs memory_usage 10/10 214.43MiB ≤ 228MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 263.54MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 368.21 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 19 ≤ 40 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 422.85MiB ≤ 455MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 72.58MiB ≤ 75MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 29.77 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 328.17MiB ≤ 355MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 63.67 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 307.41MiB ≤ 335MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 23.42 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 307.35MiB ≤ 345MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit d851389 into main Sep 3, 2026
481 of 489 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the yoanngh/netns-tc-error-classes branch September 3, 2026 17:24
@github-actions github-actions Bot added this to the 7.84.0 milestone Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed component/system-probe internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants