-
Notifications
You must be signed in to change notification settings - Fork 0
fix(release): pin PSR past GitPython break so labels can ship to PyPI #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -1462,8 +1462,10 @@ def print_form_created(form: dict[str, Any], *, updated: bool = False) -> None: | |||||||||||||
| def print_checkin_created(checkin: dict[str, Any], *, updated: bool = False) -> None: | ||||||||||||||
| """Display a created (or, with ``updated=True``, edited) check-in + summary.""" | ||||||||||||||
| name: str = str(checkin.get("name") or "") | ||||||||||||||
| checkin_id: str = str(checkin.get("id") or checkin.get("uuid") or "") | ||||||||||||||
| lines: list[str] = [f"[bold]{name}[/bold]", f"ID: {checkin_id}"] | ||||||||||||||
| checkin_uuid: str = str( | ||||||||||||||
| checkin.get("uuid") or checkin.get("id") or checkin.get("followup_uuid") or "" | ||||||||||||||
| ) | ||||||||||||||
| lines: list[str] = [f"[bold]{name}[/bold]", f"UUID: {checkin_uuid}"] | ||||||||||||||
|
Comment on lines
+1465
to
+1468
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This block inlines Prefer reusing the helper so authoring and status stay consistent:
Suggested change
|
||||||||||||||
| schedule: dict[str, Any] = checkin.get("schedule") or {} | ||||||||||||||
| if schedule: | ||||||||||||||
| days: Any = schedule.get("days") | ||||||||||||||
|
|
||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing coverage for the non-trivial branches of this helper (and two of three call sites).
The only new test exercises
checkin create --jsonwhen the payload hasidand nouuid. That leaves untested:uuid— the docstring promises never to overwrite; a regression that always copiesid→uuidwould still pass the create test.followup_uuid-only payloads — the fallback used whenidis absent.checkin config --json/checkin show --json— both call this helper in this PR, but neither assertsuuid(the existing show JSON test still only checks nested question fields).Suggested additions (unit or CliRunner):
plus a
show/config --jsonassertion thatpayload["uuid"]is present when the API returns onlyid.