Skip to content

Fix viewport scrolling and compact navigation - #12

Merged
Dacaidi merged 1 commit into
mainfrom
fix/viewport-layout
Aug 22, 2026
Merged

Fix viewport scrolling and compact navigation#12
Dacaidi merged 1 commit into
mainfrom
fix/viewport-layout

Conversation

@Dacaidi

@Dacaidi Dacaidi commented Aug 22, 2026

Copy link
Copy Markdown
Owner

Summary

  • lock document-level scrolling so the virtualized champion table cannot create a second page scrollbar
  • keep Draft, Analysis, Builds, and dialogs on their intended independent scroll containers
  • open the champion selector by default in compact layouts and return to it after choosing an empty team slot
  • reset compact navigation to Champions when resizing from desktop layout
  • label the compact navigation as Ally / Champions / Opponent
  • enforce a 480x600 minimum desktop window size

Behavior preserved

  • desktop keeps the existing three-column layout
  • Draft Analysis still opens automatically after all ten champions are filled
  • LCU synchronization no longer strands compact layouts on a team sidebar
  • extremely narrow web layouts remain accessible with table-local horizontal scrolling

Validation

  • bun typecheck
  • bun run --filter @draftgap/frontend lint
  • bun test apps/frontend/src (15 passed)
  • bun run --filter @draftgap/frontend build
  • Tauri CLI configuration check
  • browser regression at 1600x850, 1280 to 1024 resize, 480x600 cold start, and 360px web layout
  • verified one Draft scroll container, one Analysis scroll container, no document scroll, and no blank page at the bottom
  • verified LCU-style ten-pick completion still opens Draft Analysis

@Dacaidi
Dacaidi marked this pull request as ready for review August 22, 2026 16:40
@Dacaidi
Dacaidi merged commit 3cd5fe9 into main Aug 22, 2026
3 checks passed
@Dacaidi
Dacaidi deleted the fix/viewport-layout branch August 22, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant