Skip to content

Fixed the disabling of the data writing in the TPStreamWriterModule#498

Open
bieryAtFnal wants to merge 2 commits into
developfrom
kbiery/tpsw_output_disable
Open

Fixed the disabling of the data writing in the TPStreamWriterModule#498
bieryAtFnal wants to merge 2 commits into
developfrom
kbiery/tpsw_output_disable

Conversation

@bieryAtFnal

Copy link
Copy Markdown
Collaborator

Description

Some time ago, Michal reported that the --disable-data-storage option that is part of the run control start command was not causing TPStream file writing to be disabled (even though it disables the writing of raw data files).

It turns out that the "output disable" logic had not been included in the TPStreamWriterModule. This PR fixes that.

In addition, the change in this PR add the checking of the number of TPStream files written in the disabled_output_test.py regression test, which was another oversight. With the changes in this PR, this regression test runs successfully and verifies that there are no TPStream files written to disk when the --disable-data-storage flag is used.

Here are suggested instructions for testing these changes:

DATE_PREFIX=`date '+%d%b'`
TIME_SUFFIX=`date '+%H%M'`

source /cvmfs/dunedaq.opensciencegrid.org/setup_dunedaq.sh
setup_dbt latest
dbt-create -n NFD_DEV_260716_A9 ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}
cd ${DATE_PREFIX}FDDevTest_${TIME_SUFFIX}/sourcecode

git clone https://github.com/DUNE-DAQ/daqsystemtest.git -b develop
git clone https://github.com/DUNE-DAQ/dfmodules.git -b kbiery/tpsw_output_disable

cd ..

. ./env.sh
dbt-build -j 12
dbt-workarea-env

dunedaq_integtest_bundle.sh -r dfmodules -k disable

echo ""
echo -e "\U1F535 \U2705 Note that the disabled_output_test ran successfully, including the correct number of TPStream files. \U2705 \U1F535"
echo ""
echo ""

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing checklist

  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)

Further checks

I will clang-format the TPStreamWriter code as a separate step...

@bieryAtFnal bieryAtFnal changed the title Kbiery/tpsw output disable Fixed the disabling of the data writing in the TPStreamWriterModule Jul 16, 2026
@bieryAtFnal
bieryAtFnal requested a review from MRiganSUSX July 16, 2026 12:07

@eflumerf eflumerf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Updated integration test works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants