Fixed the disabling of the data writing in the TPStreamWriterModule#498
Open
bieryAtFnal wants to merge 2 commits into
Open
Fixed the disabling of the data writing in the TPStreamWriterModule#498bieryAtFnal wants to merge 2 commits into
bieryAtFnal wants to merge 2 commits into
Conversation
eflumerf
approved these changes
Jul 16, 2026
eflumerf
left a comment
Member
There was a problem hiding this comment.
Looks good. Updated integration test works fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some time ago, Michal reported that the
--disable-data-storageoption that is part of the run controlstartcommand was not causing TPStream file writing to be disabled (even though it disables the writing of raw data files).It turns out that the "output disable" logic had not been included in the
TPStreamWriterModule. This PR fixes that.In addition, the change in this PR add the checking of the number of TPStream files written in the
disabled_output_test.pyregression test, which was another oversight. With the changes in this PR, this regression test runs successfully and verifies that there are no TPStream files written to disk when the--disable-data-storageflag is used.Here are suggested instructions for testing these changes:
Type of change
Testing checklist
dunedaq_integtest_bundle.sh)Further checks
I will
clang-formatthe TPStreamWriter code as a separate step...