fix(switch_count): check print_log2_hists() result instead of stale err - #142
Open
JoeSergen wants to merge 1 commit into
Open
fix(switch_count): check print_log2_hists() result instead of stale err#142JoeSergen wants to merge 1 commit into
JoeSergen wants to merge 1 commit into
Conversation
The main loop discarded the return value of print_log2_hists() and then checked the leftover err from switch_count_bpf__attach(), which is 0 on success, so the error branch was dead code and histogram read/cleanup failures went unreported. Capture the return value into err.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #133
The main loop discarded the return value of
print_log2_hists()and then checked the leftovererrfromswitch_count_bpf__attach()(0 on success), making the error branch dead code. Capture the return value intoerr.