fix(repositories): filter unqueryable signals from dataSummary - #306
Merged
Conversation
availableSignals and signalsSnapshot already filter stored signal names against the GraphQL schema; dataSummary forwarded them raw, advertising names like currentLocationIsRedacted that fail validation when queried. Counts and first/last-seen now aggregate over queryable signals only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
dataSummaryforwards stored signal names raw from ClickHouse, whileavailableSignalsandsignalsSnapshotfilter them against the GraphQL schema's queryable set. Stored-but-removed names leak intoavailableSignals/signalDataSummary— prod example:currentLocationIsRedacted(last written 2024). Agents and API consumers feed those names back into signal queries and getGRAPHQL_VALIDATION_FAILED.Follow-up to #304 (same 2026-08-03 incident class: API advertising names that fail when queried).
Fix
GetDataSummaryapplies the samequeryableSignalsfilter before building the summary;numberOfSignalsandfirstSeen/lastSeenaggregate over queryable signals only.Tests
TestGetDataSummaryFiltersUnqueryableSignals— RED against the old code with the exact prod leak (currentLocationIsRedactedin the advertised list), GREEN after. Full suite passes.🤖 Generated with Claude Code
https://claude.ai/code/session_015hwzo7z9hmuqgJ2SHPusac