Overhaul color-schemes for v5X#1600
Open
Moth-Tolias wants to merge 1 commit into
Open
Conversation
Obsoletes DFHack#1599. Cuts out an overwhelming majority of the old script in favour of dfhack-native implementations and a simpler interface. Uses Milo Christiansen's implementation of parsing the color files, because we think it's more elegant. Removes the in-file help text in favour of the .rst documentation. Removes registration as a concept. Stores the default scheme in prefs/color.txt instead of a dedicated file. Anything that uses this script expecting it to work the same as before will break. But then, v5x broke it anyway, so i think that's fine. Only really works with the ASCII interface. We haven't written a changelog entry yet. If this looks good to you [barring a changelog entry, and other changes], we'll move on to season-palette.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obsoletes #1599.
Cuts out an overwhelming majority of the old script in favour of dfhack-native implementations and a simpler interface. Uses Milo Christiansen's implementation of parsing the color files, because we think it's more elegant.
Removes the in-file help text in favour of the .rst documentation.
Removes registration as a concept.
Stores the default scheme in prefs/color.txt instead of a dedicated file.
Anything that uses this script expecting it to work the same as before will break. But then, v5x broke it anyway, so i think that's fine.
Only really works with the ASCII interface.
We haven't written a changelog entry yet. I wanted to get feedback on this first.
If this looks good to you [barring a changelog entry, and any other changes], we'll move on to season-palette.