feat: show dynamic island on lock screen - #267
Open
DevIP98 wants to merge 6 commits into
Open
Conversation
Add a new user-configurable toggle 'Show on Lock Screen' that controls whether HyperBridge islands (standard, live update, widget, and permanent) are visible on the device lock screen. Implementation: - New preference 'show_island_on_lockscreen' (default: true) in AppPreferences - Set NotificationCompat.VISIBILITY_PUBLIC on all notification builders when the preference is enabled, so HyperOS renders focus notifications on the keyguard - New toggle in Permanent Island config screen (applies to all islands) - Added English and Spanish string resources Closes: N/A (new feature)
…t island" This reverts commit 159116d.
…bled" This reverts commit 99f135b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR introduces a user-configurable "Show on Lock Screen" toggle that configures notification visibility across all HyperBridge island builders and system notification channels.
✨ What's Changed
User Preference (
AppPreferences):show_island_on_lockscreen(boolean, defaults totrue).showIslandOnLockscreenFlowand synchronous getter.Notification Visibility (
NotificationReaderService&WidgetOverlayService):NotificationChannel.lockscreenVisibility = Notification.VISIBILITY_PUBLICacross all created channels (NOTIFICATION_CHANNEL_ID,WIDGET_CHANNEL_ID,LIVE_UPDATE_CHANNEL_ID).NotificationCompat.VISIBILITY_PUBLICto standard notification builders, native live update builders, and widget overlay builders when the setting is enabled.UI Integration:
PermanentIslandConfigScreen.PermanentIslandConfigPagestep inOnboardingScreen.Localization:
values/strings.xml) and Spanish (values-es-rES/strings.xml).📱 Notes on HyperOS Compatibility
VISIBILITY_PUBLICensures that notifications and live activities are allowed to show content on the lock screen for supported ROMs/regions.🖼️ Screenshots