Skip to content

feat(rate): add matched regional surface plan editors - #4339

Closed
d-sorgcodexagent[bot] wants to merge 6 commits into
feat/4271-regional-wire-contractfrom
feat/4274-regional-surface-ui
Closed

feat(rate): add matched regional surface plan editors#4339
d-sorgcodexagent[bot] wants to merge 6 commits into
feat/4271-regional-wire-contractfrom
feat/4274-regional-surface-ui

Conversation

@d-sorgcodexagent

Copy link
Copy Markdown
Contributor

Summary

  • add matched PyQt6 and React Ground Surfaces modules for a complete SI base material/domain and 1–8 regional overlays
  • expose IDs, precedence, finite bounds, source revision, all v1 material inputs, explicit target-frame geometry, and accessible validation/readback
  • derive provenance SHA-256 from the actual editor draft and pin Python/TypeScript parity
  • delegate both clients to the strict regional request validator from feat(ground): add regional material plan wire contract #4335; TypeScript does not run or duplicate ground physics
  • disclose that initial values are illustrative/unvalidated and that this slice is session-only validation, not calibrated course data, execution, or playback
  • preserve the corrected feat(ground): add regional material plan wire contract #4335 head through normal merge commit 6051d89a685ef009cfeef7c77bb3591cd124574a; no history rewrite
  • update navigation/help, specifications, manifest, and all canonical handoffs

Verification

  • Python adapter: 3 passed post-parent merge; earlier combined Python/PyQt editor: 5 passed, including 2 GUI cases
  • PyQt shell/help: 6 passed
  • final React editor + wire: 9 passed; navigation/view preferences: 12 passed; help: 3 passed
  • TypeScript, full and focused zero-warning ESLint, Vite production build (198 modules): passed
  • Ruff, MyPy, manifest validator + 8 manifest tests, docs governance, changed-test assertions, staged secret scan, exact-base file-size/changed-Python/diff/ancestry checks: passed

Validation boundary

A separate post-merge regional PyQt rerun and an ad hoc full-shell exit check timed out during workstation startup/lifecycle with no assertion output and are not claimed. Request import/export, measured calibration, workspace model-input persistence, execution/result playback, terrain/interval visualization, compiled/TypeScript regional physics, UpstreamDrift parity, protected CI/review, and release remain open. This does not close #4274 or #4267.

Advances #4274 under epic #4267. Depends on #4335.

@d-sorgcodexagent

Copy link
Copy Markdown
Contributor Author

Exact-head rendered QA follow-up at cbb9c0a:

  • fixed stale canonical validation evidence after any identity, interval, material, add, or remove edit on both PyQt6 and React;
  • added specific PyQt6 engineering-context tooltips after the complete tooltip contract exposed the new controls;
  • browser-proved validate -> add overlay clears readback -> remove/revalidate restores the one-overlay digest;
  • 870 Python/PyQt tests and 672 React tests pass;
  • Ruff/format/MyPy, TypeScript, zero-warning ESLint, 198-module production build, manifest/docs/file-size governance, and diff checks are green.

The polynomial-generator empty-legend warning is pre-existing and unrelated. Fresh protected checks are queued. This does not claim completion of #4274: import/export, persistence, execution, playback, measured calibration, and consumer parity remain open.

@dieterolson

Copy link
Copy Markdown
Collaborator

Consolidated into #4410. Closing to reduce CI/CD runner load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant