feat: Implement independent miner status tracking with non-blocking operational status updates - #21
feat: Implement independent miner status tracking with non-blocking operational status updates#21Nathy-bajo wants to merge 5 commits into
Conversation
tom-blk
left a comment
tom-blk
left a comment
There was a problem hiding this comment.
The way that this works now looks better, but I don't understand why update_operational_status is not in tx_builder and the check_for_acceptable_operational_status_error is essentially the same as the original check_for_acceptable_error function? Is there a specific reason for this?
49b1e1c to
67f8f03
Compare
tom-blk
left a comment
tom-blk
left a comment
There was a problem hiding this comment.
Looks good overall, but if I am understanding this correctly, the miner now gets it operational state from itself and stores in the Miner struct. That still causes an issue, because the point is for the miner to react to the chainstate so it should
- start up
- check chainstate
- update own state based on chainstate
Also is there a reason why we need the last_operational_status in the miner at all? Why is it not enough to keep track if the miner has a task with current_task or not?
2 participants
No description provided.