cuprated: stop the block downloader when shutting down - #703
Open
redsh4de wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
A-p2p
SyntheticBird45
approved these changes
Sep 8, 2026
SyntheticBird45
left a comment
SyntheticBird45
left a comment
Member
There was a problem hiding this comment.
i don't like the tuple being handed around, but apart from that LGTM
Contributor
Author
|
Thoughts on wrapping the stream and task into a |
Member
i'm all for it |
SyntheticBird45
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ensures the block downloader task is stopped as the node is shutting down to prevent a panic on graceful shutdown
Where
cuprated,p2pHow
Return the spawned downloader task and abort it as we break out of the syncer loop when shutting down