Fix CaseClauseError on WebSocket close frame - #86
Open
matthiaz wants to merge 1 commit into
Open
Conversation
Mint.WebSocket.stream/2 can return {:error, conn, %Mint.HTTPError{}, _}
when the server sends a WebSocket close frame after the HTTP/1 request
is already complete. The existing case clauses only matched
Mint.TransportError, causing a CaseClauseError that crashes the
connection process.
Add a catch-all {:error, conn, reason, _} clause that treats any
unhandled error as a graceful ChannelClosed event, allowing the client
to handle it via handle_disconnect/2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mint.WebSocket.stream/2 can return {:error, conn, %Mint.HTTPError{}, _} when the server sends a WebSocket close frame after the HTTP/1 request is already complete. The existing case clauses only matched Mint.TransportError, causing a CaseClauseError that crashes the connection process.
Add a catch-all {:error, conn, reason, _} clause that treats any unhandled error as a graceful ChannelClosed event, allowing the client to handle it via handle_disconnect/2.