identity: point the verification iframe at the identity-verification route - #2011
Draft
AngelPaella wants to merge 1 commit into
Draft
identity: point the verification iframe at the identity-verification route#2011AngelPaella wants to merge 1 commit into
AngelPaella wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ENG4-337. Pairs with the backend rename in Paella-Labs/crossbit-main.
CrossmintIdentityVerificationframes a Crossmint-hosted route. That route is moving from/sdk/unstable/kyc-verificationto/sdk/unstable/identity-verification, so the SDK's copy of the path moves with it. The two have to ship together or the component frames a dead URL.Why now
Nothing consumes the route yet, and
client-sdk-basehas not published the identity surface (latest on npm is 2.6.0, which predates the feature). Renaming the path costs nothing today. Once 2.7.0 is out and integrators have it in a lockfile, it stops being free.What is not in here
The
kyc:*event keys stay. Every event-key namespace in this repo is a kebab-case domain noun (payment-method:,order:,payment:,quote:,ui:), never a camelCase feature name, andpayment-method:selectedalready ships from a route directory calledpayment-method-management. The wire has never mirrored a product-surface name, sokyc:is the domain noun and it is already correct.The parent still never calls
handshakeWithChild(), so the child's events go out blind. That belongs with the target-origin decision in ENG4-354, not here.Changeset
None added on purpose. The identity feature is unreleased and the open release PR already queues it as
client-sdk-base@2.7.0, so this path change rides that changeset.Verification
pnpm test:vitest --filter @crossmint/client-sdk-base --filter @crossmint/client-sdk-react-ui