Expose only selectable tools over MCP server - #127
Merged
Conversation
The MCP list and call handlers exposed every non-hidden tool, including system tools that agents auto-include based on context. They now gate on AIToolDefinitionEntry.IsSelectable() so system and hidden tools are never listed or callable over MCP, even when ExposeAllTools is true. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
MikeAlhayek
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MCP server list and call handlers (
WithCrestAppsHandlers()) exposed every non-hidden tool, including system tools that agents auto-include based on context. Both handlers now gate onAIToolDefinitionEntry.IsSelectable()(!IsSystemTool && !Hidden), so system and hidden tools are never listed or callable over MCP — even whenExposeAllToolsistrue. Tool instances are unchanged (user-created, always selectable).This restores the intended behavior:
release/1.0filtered only!Hidden, so it also leaked non-hidden system tools; this fix applies the framework's existing selectable-tool concept to MCP.Changes
ResolveAllowedCodeTool) to selectable tools onlyExposeAllToolslisting; system tool rejected by call handlermcp/server.mdexposure section +changelog/1.1.0.mdFixes entryValidation
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com