security: remove hardcoded secrets, migrate to environment variables#533
Open
Osuochasam wants to merge 1 commit into
Open
security: remove hardcoded secrets, migrate to environment variables#533Osuochasam wants to merge 1 commit into
Osuochasam wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sensitive credentials were previously present in source/config files.
This change moves all secrets to environment variables and documents
what's required to configure the app.
Changes
hardcoded secrets
placeholder and description
variable, its purpose, and where to obtain it
Notes
<file/commit> — flagging for manual rotation and history cleanup,
not handled by this change.
commits during this review.
Testing
App boots and functions correctly using .env populated from
.env.example. No functional/logic changes beyond credential sourcing.
Follow-up
Requesting a security review pass before merge, per acceptance
criteria.
Adds gas/resource usage tracking for critical contract functions so
regressions in efficiency are caught automatically instead of
discovered later.
Changes
budget tracking, run under representative test scenarios
conditions under which it was measured
usage increases beyond % versus the committed snapshot
Testing
Snapshot generation and comparison verified locally; CI step tested
against both a passing (no regression) and failing (artificial
regression) case.
Expands subscription test coverage beyond the happy path to include
duplicate requests, invalid inputs, and boundary conditions, per the
acceptance criteria.
Changes
submitted twice, both immediately and after elapsed time. Verified
<actual/expected behavior — e.g. "second request is a no-op" or
"second request extends the existing subscription">.
deactivated channel IDs, confirming the contract returns a clear
error rather than panicking or succeeding silently.
expiry timestamp, zero- and max-value duration/amount inputs, and
rapid subscribe/unsubscribe sequences.
Notes
as worth a follow-up discussion — current behavior is
tested as-is but may not be the intended design.
Testing
All new and existing tests pass
Closes #402
Closes #406
Closes #407