Add job monitoring, bulk import, channel update events, and notification export#532
Open
amanosiadnan-cmyk wants to merge 1 commit into
Open
Conversation
|
@amanosiadnan-cmyk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #492
closes #489
closes #481
closes #502
PR description
Summary
JobMonitorrecords scheduled job status; failures are logged; APIs + docs for maintenance.ChannelPreferenceUpdatedon channel preference changes, with tests.Task 1 — Add Background Job Monitoring
listener/src/services/job-monitor.tstracksrunning/completed/failedjobs.NotificationSchedulerso each scheduled notification is monitored.logger.errorand retained in a failure list.GET /api/schedule/jobs,GET /api/schedule/jobs/failuresdocs/JOB_MONITORING.md(+ link fromdocs/MONITORING_INTEGRATION.md)job-monitor.test.tsTask 2 — Support Bulk Notification Import
NotificationImportServiceaccepts JSON arrays /{ notifications: [] }or CSV.NotificationAPI.POST /api/notifications/import(honorsX-API-Keywhen configured)total,imported,skipped,importedIds,skippedRecords,format,durationMsdocs/BULK_NOTIFICATION_IMPORT.mdnotification-import-service.test.tsTask 3 — Emit Event for Channel Updates
ChannelPreferenceUpdatedevent inbase/events.rswithrecipient,channel,enabled,updated_at(+ category/priority topics).set_channel_preference,set_preferences, andreset_preferences.preferences_test.rsassert emission and per-channel counts.Task 4 — Add Notification Export Button
NotificationSearchPage(JSON/CSV).dashboard/src/utils/notificationExport.ts,docs/NOTIFICATION_EXPORT_FORMAT.mdnotificationExport.test.tsTest plan
GET /api/schedule/jobsreturns snapshot after scheduler activity/api/schedule/jobs/failuresand logsPOST /api/notifications/importwith mixed valid/invalid JSON → summary shows skip + importset_channel_preferenceemitschannel_preference_updateddocs/NOTIFICATION_EXPORT_FORMAT.md