feat(#378): implement structured logging#519
Open
Rayhab2000 wants to merge 1 commit into
Open
Conversation
- logger.ts: add resolveLogLevel(), LogContext type, createRequestContext(), configureLogger() and LogLevel exports. Replace open-ended LOG_LEVEL fallback with validated resolveLogLevel() so invalid values default silently to 'info'. Update formatMeta to accept LogContext. Add JSDoc on all public helpers and the logger object itself. - logger.test.ts: expand test coverage from 3 (formatError only) to full suite: formatError (10 cases), resolveLogLevel (7), createRequestContext (2), configureLogger (2), logger method smoke tests (11), error field normalisation (2), export surface (3), log-level integration (2). Total: ~39 tests. - batch-validator.ts: replace 4 bare console.log/warn calls in runTerminalSimulation() with structured logger calls carrying context fields (status, processedCount, errorCount, reportPath, index, field, code). Closes Core-Foundry#378
|
@Rayhab2000 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logger.ts: add resolveLogLevel(), LogContext type, createRequestContext(), configureLogger() and LogLevel exports. Replace open-ended LOG_LEVEL fallback with validated resolveLogLevel() so invalid values default silently to 'info'. Update formatMeta to accept LogContext. Add JSDoc on all public helpers and the logger object itself.
logger.test.ts: expand test coverage from 3 (formatError only) to full suite: formatError (10 cases), resolveLogLevel (7), createRequestContext (2), configureLogger (2), logger method smoke tests (11), error field normalisation (2), export surface (3), log-level integration (2). Total: ~39 tests.
batch-validator.ts: replace 4 bare console.log/warn calls in runTerminalSimulation() with structured logger calls carrying context fields (status, processedCount, errorCount, reportPath, index, field, code).
Closes #378