feat(#375): emit SubscriptionCancelled event on subscription cancella…#468
Merged
Abd-Standard merged 2 commits intoJul 26, 2026
Conversation
…ion cancellation - Add SubscriptionCancelled contractevent struct to base/events.rs Topics: group_id, subscriber, category (Group), priority (Medium) Data: cancelled_at (ledger timestamp) - Add cancel_subscription() to autoshare_logic.rs Validates: auth, paused, group exists, caller is creator/member, group is currently active. Deactivates group and zeroes usage count. - Expose cancel_subscription() as a public contract method in lib.rs under the Subscription Management section. - Add subscription_cancellation_test.rs with 8 tests covering: event emission, topic shape, cancelled_at data, group deactivation, non-member rejection, double-cancel rejection, paused-contract rejection, member (non-creator) cancellation, unknown-group panic. Closes Core-Foundry#375
|
@Rayhab2000 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tion
Add SubscriptionCancelled contractevent struct to base/events.rs Topics: group_id, subscriber, category (Group), priority (Medium)
Data: cancelled_at (ledger timestamp)
Add cancel_subscription() to autoshare_logic.rs Validates: auth, paused, group exists, caller is creator/member, group is currently active. Deactivates group and zeroes usage count.
Expose cancel_subscription() as a public contract method in lib.rs under the Subscription Management section.
Add subscription_cancellation_test.rs with 8 tests covering: event emission, topic shape, cancelled_at data, group deactivation, non-member rejection, double-cancel rejection, paused-contract rejection, member (non-creator) cancellation, unknown-group panic.
Closes #375