Feature/notification expiration#462
Open
vicajohn wants to merge 2 commits into
Open
Conversation
- Add ExpirationConfig interface with configurable default and per-event-type expiration - Create NotificationExpirationService with core expiration checking logic - Integrate expiration checks into EventSubscriber to prevent processing of expired events - Add comprehensive test suite with 38+ tests covering all methods and edge cases - Update configuration schema with EXPIRATION_* environment variables - Update .env.example with expiration settings examples - Log expired events with full context for audit trail Fixes expired notifications being processed and delivered Supports 24-hour default expiration with configurable per-event-type overrides Expiration checking can be disabled via config for backward compatibility
|
@vicajohn Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
please review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ Implemented notification expiration support
This pull request introduces expiration handling for notifications to ensure that outdated notifications are not processed or delivered after their validity period has elapsed.
Changes made:
Added an expirationTimestamp field to the notification model to define the time at which a notification becomes invalid.
Updated the notification processing workflow to check the expiration timestamp before processing. Any notification that has passed its expiration time is skipped, preventing unnecessary processing and delivery of stale notifications.
Ensured that only notifications with a valid (non-expired) expiration timestamp proceed through the processing pipeline.
Added comprehensive unit tests covering both successful and failure scenarios, including:
Processing notifications that have not yet expired.
Rejecting notifications whose expiration time has already passed.
Verifying that the expiration validation behaves correctly across different edge cases.
close #369