π¨ Palette: ν μ»΄ν¬λνΈ ν€λ³΄λ νμ(Roving tabindex) μ§μ#86
π¨ Palette: ν μ»΄ν¬λνΈ ν€λ³΄λ νμ(Roving tabindex) μ§μ#86seonghobae wants to merge 1 commit into
Conversation
- WAI-ARIA ν λμμΈ ν¨ν΄μ λ°λΌ ν μ»΄ν¬λνΈμ Roving tabindex μ§μμ μΆκ°νμ΅λλ€. - μ νλ νλ§ `tabindex="0"`μ κ°μ§κ³ λλ¨Έμ§λ `-1`μ κ°μ Έ ν ν€λ‘ ν¨λμ λ°λ‘ μ κ·Όν μ μμ΅λλ€. - λ°©ν₯ν€(`ArrowRight`, `ArrowLeft`)λ₯Ό μ¬μ©νμ¬ νμ μ΄λνκ³ μ νν μ μλλ‘ `keydown` μ΄λ²€νΈλ₯Ό μ²λ¦¬νμ΅λλ€. - μ€ν¬λ¦° 리λ μ¬μ©μλ₯Ό μν΄ `tablist`μ `aria-label`μ μΆκ°νμ΅λλ€.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π‘ What: KRDS ν μ»΄ν¬λνΈμ Roving tabindexμ λ°©ν₯ν€ νμ κΈ°λ₯μ μΆκ°νμ΅λλ€.
π― Why: κΈ°μ‘΄μλ λͺ¨λ νμ΄ μμ°μ€λ¬μ΄ ν μμ(natural tab order)μ ν¬ν¨λμ΄ μμ΄ ν€λ³΄λ μ¬μ©μκ° ν ν¨λ λ΄μ©μΌλ‘ μ§μ νκΈ° μν΄ λͺ¨λ νμ μμ°¨μ μΌλ‘ ν΅κ³Όν΄μΌ νλ λΆνΈν¨μ΄ μμμ΅λλ€.
πΈ Before/After: μκ°μ λ³νλ μμ§λ§, ν€λ³΄λ νμ κ²½νμ΄ ν¬κ² κ°μ λμμ΅λλ€. λ°©ν₯ν€λ‘ ν μ νμ΄ κ°λ₯ν©λλ€.
βΏ Accessibility: WAI-ARIA ν κΆμ₯ ν¨ν΄(Roving tabindex)μ μ€μνλλ‘ κ°μ νκ³ ,
tablistμaria-labelμ μΆκ°ν΄ 컨ν μ€νΈλ₯Ό λͺ νν νμ΅λλ€.PR created automatically by Jules for task 2449457969914145042 started by @seonghobae