Skip to content

🎨 Palette: νƒ­ μ»΄ν¬λ„ŒνŠΈ ν‚€λ³΄λ“œ 탐색(Roving tabindex) 지원#86

Open
seonghobae wants to merge 1 commit into
mainfrom
palette-tabs-a11y-2449457969914145042
Open

🎨 Palette: νƒ­ μ»΄ν¬λ„ŒνŠΈ ν‚€λ³΄λ“œ 탐색(Roving tabindex) 지원#86
seonghobae wants to merge 1 commit into
mainfrom
palette-tabs-a11y-2449457969914145042

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

πŸ’‘ What: KRDS νƒ­ μ»΄ν¬λ„ŒνŠΈμ— Roving tabindex와 λ°©ν–₯ν‚€ 탐색 κΈ°λŠ₯을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Why: κΈ°μ‘΄μ—λŠ” λͺ¨λ“  탭이 μžμ—°μŠ€λŸ¬μš΄ νƒ­ μˆœμ„œ(natural tab order)에 ν¬ν•¨λ˜μ–΄ μžˆμ–΄ ν‚€λ³΄λ“œ μ‚¬μš©μžκ°€ νƒ­ νŒ¨λ„ λ‚΄μš©μœΌλ‘œ μ§„μž…ν•˜κΈ° μœ„ν•΄ λͺ¨λ“  탭을 순차적으둜 톡과해야 ν•˜λŠ” λΆˆνŽΈν•¨μ΄ μžˆμ—ˆμŠ΅λ‹ˆλ‹€.
πŸ“Έ Before/After: μ‹œκ°μ  λ³€ν™”λŠ” μ—†μ§€λ§Œ, ν‚€λ³΄λ“œ 탐색 κ²½ν—˜μ΄ 크게 κ°œμ„ λ˜μ—ˆμŠ΅λ‹ˆλ‹€. λ°©ν–₯ν‚€λ‘œ νƒ­ μ „ν™˜μ΄ κ°€λŠ₯ν•©λ‹ˆλ‹€.
β™Ώ Accessibility: WAI-ARIA νƒ­ ꢌμž₯ νŒ¨ν„΄(Roving tabindex)을 μ€€μˆ˜ν•˜λ„λ‘ κ°œμ„ ν•˜κ³ , tablist에 aria-label을 μΆ”κ°€ν•΄ μ»¨ν…μŠ€νŠΈλ₯Ό λͺ…ν™•νžˆ ν–ˆμŠ΅λ‹ˆλ‹€.


PR created automatically by Jules for task 2449457969914145042 started by @seonghobae

- WAI-ARIA νƒ­ λ””μžμΈ νŒ¨ν„΄μ— 따라 νƒ­ μ»΄ν¬λ„ŒνŠΈμ— Roving tabindex 지원을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
- μ„ νƒλœ νƒ­λ§Œ `tabindex="0"`을 κ°€μ§€κ³  λ‚˜λ¨Έμ§€λŠ” `-1`을 κ°€μ Έ νƒ­ ν‚€λ‘œ νŒ¨λ„μ— λ°”λ‘œ μ ‘κ·Όν•  수 μžˆμŠ΅λ‹ˆλ‹€.
- λ°©ν–₯ν‚€(`ArrowRight`, `ArrowLeft`)λ₯Ό μ‚¬μš©ν•˜μ—¬ 탭을 μ΄λ™ν•˜κ³  선택할 수 μžˆλ„λ‘ `keydown` 이벀트λ₯Ό μ²˜λ¦¬ν–ˆμŠ΅λ‹ˆλ‹€.
- 슀크린 리더 μ‚¬μš©μžλ₯Ό μœ„ν•΄ `tablist`에 `aria-label`을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant