fix(emitter): split at CHROME_BODY_SLOT before filling marks (finding #6, 49.8→97.8) - #136
Merged
Conversation
✅ Deploy Preview for contentrain-ai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ne
Bulgu #6 (dört satırlık bağımsız yeniden üretimle kanıtlanmış, ölçülen bedel 49.8 → 97.8): üretilen layout, markları doldurduktan SONRA işaretçide ayırıyordu —
fillMarks'ın@@…@@deseni<!--@@body@@-->içindeki@@body@@'yi yiyor, geriye<!---->kalıyor,split(BODY_SLOT)hiçbir şey bulamıyor ve gövde sessizce düşüyordu.Düzeltme (öneri 1): üretilen
fill.ts'ecomposeBodyeklendi — önce işaretçide ayır, sonra her yarıyı doldur:Layout artık
composeBody(chrome.body, marks, content)çağırıyor. Sözleşme sabiti (CHROME_BODY_SLOT) değişmedi — bu bir uygulama-sırası hatasıydı.Test
<!---->kalıntısıyla) ve ayır-sonra-doldur sırasının koruduğunu kanıtlarcomposeBodykullanır,fillMarks(chrome.bodyiçermez;fill.ts'te split filling'den önce gelir🤖 Generated with Claude Code
https://claude.ai/code/session_01NjgQYCFqwZjJt97yioyjnS