Bump sonLib to the head of sonLib#28 - #77
Merged
Merged
Conversation
deps/sonLib was pinned at c660699, behind sonLib master. This moves it to cbb2285, which is master (f81bde0, taking in sonLib#27's write-error checking) plus the two commits of ComparativeGenomicsToolkit/sonLib#28 "Determinism patches for stHash and st_random" namely iterating hashes in insertion order and giving the random number generator per-thread state. Both matter here: hash iteration order and a shared RNG are the two things that make a run's output depend on something other than its input, and hal2vg is expected to be reproducible. Note this pins an unmerged PR head. It needs re-pointing at the merge commit once sonLib#28 lands, and if that branch is rebased or squashed first, cbb2285 stops being reachable from any branch and a fresh `git submodule update --init` against it will fail. Full build and `make test-only` (88 tests) pass against it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017JHRYj2XJLaBCZxavo51TX (cherry picked from commit 0bb6906)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deps/sonLib was pinned at c660699, behind sonLib master. This moves it to cbb2285, which is master (f81bde0, taking in sonLib#27's write-error checking) plus the two commits of
ComparativeGenomicsToolkit/sonLib#28
"Determinism patches for stHash and st_random"
namely iterating hashes in insertion order and giving the random number generator per-thread state. Both matter here: hash iteration order and a shared RNG are the two things that make a run's output depend on something other than its input, and hal2vg is expected to be reproducible.
Note this pins an unmerged PR head. It needs re-pointing at the merge commit once sonLib#28 lands, and if that branch is rebased or squashed first, cbb2285 stops being reachable from any branch and a fresh
git submodule update --initagainst it will fail.Full build and
make test-only(88 tests) pass against it.Claude-Session: https://claude.ai/code/session_017JHRYj2XJLaBCZxavo51TX (cherry picked from commit 0bb6906)