Skip to content

Bump Microsoft.AspNetCore.OpenApi globally and remove local override - #1515

Open
aaronpowell with Copilot wants to merge 2 commits into
mainfrom
copilot/update-openapi-nuget-package
Open

Bump Microsoft.AspNetCore.OpenApi globally and remove local override#1515
aaronpowell with Copilot wants to merge 2 commits into
mainfrom
copilot/update-openapi-nuget-package

Conversation

Copilot AI commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

The OpenAPI package version was only bumped locally in one example project, creating drift from central package management. This change moves the upgrade to central package definitions so all projects resolve the same OpenAPI version.

  • Global package management

    • Updated Directory.Packages.props:
      • Microsoft.AspNetCore.OpenApi: 8.0.2010.0.10
  • Local override cleanup

    • Removed the per-project VersionOverride in examples/surrealdb/CommunityToolkit.Aspire.Hosting.SurrealDb.ApiService/CommunityToolkit.Aspire.Hosting.SurrealDb.ApiService.csproj so it now inherits the centrally managed version.
  • Resulting dependency shape

    • OpenAPI version ownership is now centralized, avoiding project-level version pinning for this package.
<!-- Directory.Packages.props -->
<PackageVersion Include="Microsoft.AspNetCore.OpenApi" Version="10.0.10" />

<!-- SurrealDb ApiService.csproj -->
<PackageReference Include="Microsoft.AspNetCore.OpenApi" />

Copilot AI linked an issue Aug 6, 2026 that may be closed by this pull request
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Copilot AI changed the title [WIP] Update OpenAPI NuGet package globally Bump Microsoft.AspNetCore.OpenApi globally and remove local override Aug 6, 2026
Copilot AI requested a review from aaronpowell August 6, 2026 04:36
@aaronpowell
aaronpowell marked this pull request as ready for review August 7, 2026 02:11
@aaronpowell
aaronpowell requested a review from Odonno as a code owner August 7, 2026 02:11
Copilot AI lite review requested due to automatic review settings August 7, 2026 02:11
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1515

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1515"

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR centralizes the Microsoft.AspNetCore.OpenApi package version in the repo’s central package management to eliminate drift caused by a per-project override in an example project.

Changes:

  • Updated central package version for Microsoft.AspNetCore.OpenApi in Directory.Packages.props from 8.0.20 to 10.0.10.
  • Removed the VersionOverride for Microsoft.AspNetCore.OpenApi in the SurrealDb ApiService example so it inherits the centrally managed version.
Show a summary per file
File Description
Directory.Packages.props Bumps Microsoft.AspNetCore.OpenApi centrally so all projects resolve the same version.
examples/surrealdb/CommunityToolkit.Aspire.Hosting.SurrealDb.ApiService/CommunityToolkit.Aspire.Hosting.SurrealDb.ApiService.csproj Removes the local VersionOverride to rely on central package management.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

@Odonno

Odonno commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Ah yes, we should also set the Microsoft.OpenApi package to each failing project because for some reason it tries to pull the 2.0.0 version with vulnerabiities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update OpenAPI NuGet package globally

4 participants