Bump Microsoft.AspNetCore.OpenApi globally and remove local override - #1515
Open
aaronpowell with Copilot wants to merge 2 commits into
Open
Bump Microsoft.AspNetCore.OpenApi globally and remove local override#1515aaronpowell with Copilot wants to merge 2 commits into
Microsoft.AspNetCore.OpenApi globally and remove local override#1515aaronpowell with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update OpenAPI NuGet package globally
Bump Aug 6, 2026
Microsoft.AspNetCore.OpenApi globally and remove local override
aaronpowell
marked this pull request as ready for review
August 7, 2026 02:11
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1515Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1515" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR centralizes the Microsoft.AspNetCore.OpenApi package version in the repo’s central package management to eliminate drift caused by a per-project override in an example project.
Changes:
- Updated central package version for
Microsoft.AspNetCore.OpenApiinDirectory.Packages.propsfrom8.0.20to10.0.10. - Removed the
VersionOverrideforMicrosoft.AspNetCore.OpenApiin the SurrealDb ApiService example so it inherits the centrally managed version.
Show a summary per file
| File | Description |
|---|---|
| Directory.Packages.props | Bumps Microsoft.AspNetCore.OpenApi centrally so all projects resolve the same version. |
| examples/surrealdb/CommunityToolkit.Aspire.Hosting.SurrealDb.ApiService/CommunityToolkit.Aspire.Hosting.SurrealDb.ApiService.csproj | Removes the local VersionOverride to rely on central package management. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
Contributor
|
Ah yes, we should also set the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenAPI package version was only bumped locally in one example project, creating drift from central package management. This change moves the upgrade to central package definitions so all projects resolve the same OpenAPI version.
Global package management
Directory.Packages.props:Microsoft.AspNetCore.OpenApi:8.0.20→10.0.10Local override cleanup
VersionOverrideinexamples/surrealdb/CommunityToolkit.Aspire.Hosting.SurrealDb.ApiService/CommunityToolkit.Aspire.Hosting.SurrealDb.ApiService.csprojso it now inherits the centrally managed version.Resulting dependency shape