Skip to content

fix: fail CLA allowlist step on API errors - #135

Merged
comfyui-wiki merged 1 commit into
mainfrom
fix/cla-api-failure-handling
Aug 21, 2026
Merged

fix: fail CLA allowlist step on API errors#135
comfyui-wiki merged 1 commit into
mainfrom
fix/cla-api-failure-handling

Conversation

@alexisrolland

Copy link
Copy Markdown
Member

Summary

Make the CLA author allowlist step fail when its GitHub API request fails instead of silently continuing with only the base allowlist.

Changes

  • Capture the pull request commit API response before filtering authors.
  • Fail explicitly when the API request or pagination fails.
  • Preserve the valid author-only case where filtering produces no co-authors.

Verification

The shared implementation was validated for author-only, co-author, and simulated API-failure scenarios in Comfy-Org/comfy-cla.

Propagates Comfy-Org/comfy-cla#1 and addresses Comfy-Org/ComfyUI_frontend#15555.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 9d337661-dd43-430f-88d3-c04bd33a6623

📥 Commits

Reviewing files that changed from the base of the PR and between 4c9b6b7 and 39fbc01.

📒 Files selected for processing (1)
  • .github/workflows/cla.yml
 _________________________________________
< Making HAL 9000 open the pod bay doors. >
 -----------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cla-api-failure-handling
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/cla-api-failure-handling

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@comfyui-wiki
comfyui-wiki merged commit 2196014 into main Aug 21, 2026
3 of 4 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 21, 2026
@github-actions
github-actions Bot deleted the fix/cla-api-failure-handling branch August 21, 2026 18:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants