fix: correct DYNAMIC_COMBO data type variants in existing node docs - #130
Open
lin-bot23 wants to merge 3 commits into
Open
fix: correct DYNAMIC_COMBO data type variants in existing node docs#130lin-bot23 wants to merge 3 commits into
lin-bot23 wants to merge 3 commits into
Conversation
Normalizes DYNAMICCOMBO / DYNAMIC COMBO / plain COMBO on DynamicCombo inputs to DYNAMIC_COMBO across existing docs (15 nodes: BriaEraser, BriaExpandImage, BriaIncreaseResolution, ColorTransfer, ElevenLabs×4, HitPawVideoEnhance, MagnificImageRelightNode, Meshy×2, QuiverImageToSVGNode, Tencent×2). Plain Combo inputs kept as COMBO.
|
Important Review skippedToo many files! This PR contains 180 files, which is 80 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (180)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Resolve conflicts in ElevenLabsSpeechToSpeech/fa.md and ja.md: keep main's newer source-aligned wording and localized Required column (はい/いいえ → 必須/任意), apply the PR's DYNAMICCOMBO → DYNAMIC_COMBO type fix on top.
Follow-up to make the type normalization consistent in every language,
verified against ComfyUI source schemas (nodes_bria.py, nodes_elevenlabs.py):
- BriaEraser (11 langs): mask_type STRING -> COMBO, moderation STRING ->
DYNAMIC_COMBO (tr.md was the only language already fixed)
- BriaExpandImage (12 langs): expand_mode COMBO -> DYNAMIC_COMBO,
moderation COMBO -> DYNAMIC_COMBO (both are IO.DynamicCombo.Input)
- BriaIncreaseResolution (12 langs): moderation COMBO -> DYNAMIC_COMBO
- ElevenLabsSpeechToText (12 langs): model COMBO -> DYNAMIC_COMBO,
incl. languages with localized parameter names and the ru.md files
whose 'Входные параметры' heading had been missed
- HitPawVideoEnhance/ar, Meshy{Image,Text}ToModelNode/{es,fr,pt-BR,ar}:
normalize localized type cells (e.g. COMBO DYNAMIQUE, قائمة منسدلة
ديناميكية) to the canonical English spellings
- Remove '以下が翻訳結果です。' AI-artifact lines from 7 ja.md files
Verified: all 15 nodes now have identical type sequences across all
12 languages, matching the node source schemas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalizes incorrect data type spellings on DynamicCombo inputs in 15 existing node docs, verified against ComfyUI source schemas (
comfy_api_nodes/nodes_bria.py,nodes_elevenlabs.py):DYNAMICCOMBO(no underscore) →DYNAMIC_COMBO— zero residue repo-wideDYNAMIC COMBO(space) →DYNAMIC_COMBOCOMBO/STRINGonIO.DynamicCombo.Inputparams →DYNAMIC_COMBOCOMBONodes
BriaEraser, BriaExpandImage, BriaIncreaseResolution, ColorTransfer, ElevenLabsSpeechToSpeech, ElevenLabsSpeechToText, ElevenLabsTextToDialogue, ElevenLabsTextToSpeech, HitPawVideoEnhance, MagnificImageRelightNode, MeshyImageToModelNode, MeshyTextToModelNode, QuiverImageToSVGNode, TencentImageToModelNode, TencentTextToModelNode
Review follow-ups (commits f05b3b7, 9fee1ca)
mask_typeSTRING→COMBO,moderationSTRING→DYNAMIC_COMBO), BriaExpandImage (expand_mode,moderation), BriaIncreaseResolution (moderation), and ElevenLabsSpeechToText (model) are fixed in all 12 languages, including ru.md files using theВходные параметрыheading and languages with localized parameter names.COMBO DYNAMIQUE,قائمة منسدلة ديناميكية) — normalized to canonical English spellings per doc_rules.以下が翻訳結果です。AI-artifact lines from 7 ja.md files.Verification
ElevenLabsTextToDialogue.model(IO.Combo.Input, options=["eleven_v3"]) correctly staysCOMBO;inputs(IO.DynamicCombo.Input) isDYNAMIC_COMBONote: a repo-wide sweep found pre-existing localized type values in nodes outside this PR's scope (e.g. BasicScheduler, ControlNetApply). Those predate this PR and are intentionally left for a separate cleanup.