This repository was archived by the owner on Jun 26, 2026. It is now read-only.
[codex] Handle Git for Windows outside inherited PATH - #1703
Draft
paulreginaphoto wants to merge 1 commit into
Draft
[codex] Handle Git for Windows outside inherited PATH#1703paulreginaphoto wants to merge 1 commit into
paulreginaphoto wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
ComfyUI Desktop validated Git with only an inherited shell PATH check. On Windows, launching from Explorer can inherit a stale PATH after Git or the Desktop app has been installed or updated, causing a false "Git is missing" maintenance page even when Git is installed.
Fixes #1702
Validation
npx vitest run tests/unit/utils.test.ts tests/unit/install/installationManager.test.tsnpx eslint --max-warnings 0 src tests/unit/utils.test.ts tests/unit/install/installationManager.test.tsnpx tsc -p tsconfig.json --noEmit┆Issue is synchronized with this Notion page by Unito