Skip to content
This repository was archived by the owner on Jun 26, 2026. It is now read-only.

[codex] Handle Git for Windows outside inherited PATH - #1703

Draft
paulreginaphoto wants to merge 1 commit into
Comfy-Org:mainfrom
paulreginaphoto:codex/fix-windows-git-detection
Draft

[codex] Handle Git for Windows outside inherited PATH#1703
paulreginaphoto wants to merge 1 commit into
Comfy-Org:mainfrom
paulreginaphoto:codex/fix-windows-git-detection

Conversation

@paulreginaphoto

@paulreginaphoto paulreginaphoto commented Apr 28, 2026

Copy link
Copy Markdown

Summary

  • add a dedicated Git detection helper that keeps the existing PATH probe
  • on Windows, fall back to standard Git for Windows install locations under Program Files
  • use the helper for both fresh-install and installed-state validation

Root Cause

ComfyUI Desktop validated Git with only an inherited shell PATH check. On Windows, launching from Explorer can inherit a stale PATH after Git or the Desktop app has been installed or updated, causing a false "Git is missing" maintenance page even when Git is installed.

Fixes #1702

Validation

  • npx vitest run tests/unit/utils.test.ts tests/unit/install/installationManager.test.ts
  • npx eslint --max-warnings 0 src tests/unit/utils.test.ts tests/unit/install/installationManager.test.ts
  • npx tsc -p tsconfig.json --noEmit

┆Issue is synchronized with this Notion page by Unito

@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ee83b869-f592-4480-9cbd-71658dd73964

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Windows Desktop falsely reports “Git is missing” when launched with stale Explorer PATH

1 participant