Skip to content
This repository was archived by the owner on Jun 26, 2026. It is now read-only.

Add IPC close confirmation flow for Desktop - #1588

Draft
benceruleanlu wants to merge 1 commit into
mainfrom
fix/close-confirmation-ipc
Draft

Add IPC close confirmation flow for Desktop#1588
benceruleanlu wants to merge 1 commit into
mainfrom
fix/close-confirmation-ipc

Conversation

@benceruleanlu

@benceruleanlu benceruleanlu commented Feb 4, 2026

Copy link
Copy Markdown
Member

Summary

  • Add IPC close-request/response so the main process asks the renderer whether to close
  • Gate all close paths (window close, tray quit, IPC quit) through the confirmation flow
  • Add timeout + sender validation for safety

Testing

  • yarn format
  • yarn lint
  • yarn typecheck

Linked PRs

Fixes #1585

┆Issue is synchronized with this Notion page by Unito

@coderabbitai

coderabbitai Bot commented Feb 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/close-confirmation-ipc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

1 participant