Skip to content

Break/pure parametrized function - #579

Open
grayson-helmholz wants to merge 3 commits into
mainfrom
BREAK/pure-parametrized-function
Open

Break/pure parametrized function#579
grayson-helmholz wants to merge 3 commits into
mainfrom
BREAK/pure-parametrized-function

Conversation

@grayson-helmholz

Copy link
Copy Markdown
Contributor

Closes #568

@grayson-helmholz grayson-helmholz linked an issue Aug 7, 2026 that may be closed by this pull request
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@redeboer redeboer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'TensorWaves benchmark results'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: b818ba1 Previous: dadc908 Ratio
benchmarks/expression.py::test_fit[1000-ScipyMinimizer-numpy] 7.067198373578674 iter/sec (stddev: 0.0006566206798525118) 15.653084369591935 iter/sec (stddev: 0.0008327728665216672) 2.21
benchmarks/expression.py::test_fit[1000-ScipyMinimizer-numba] 6.950944860503677 iter/sec (stddev: 0.0007231228780639494) 15.57675266668666 iter/sec (stddev: 0.00019544090300604612) 2.24
benchmarks/expression.py::test_fit[1000-ScipyMinimizer-tf] 0.6204018518144632 iter/sec (stddev: 0.0031506456032551738) 1.4336772024447277 iter/sec (stddev: 0.002264740294580996) 2.31
benchmarks/unbinned_nll.py::test_unbinned_nll_normalization_formula[original-numpy] 29.237973075993775 iter/sec (stddev: 0.00029802421855302494) 82.89554185733245 iter/sec (stddev: 0.00047803677168886747) 2.84
benchmarks/unbinned_nll.py::test_unbinned_nll_normalization_formula[optimized-numpy] 37.661080405219295 iter/sec (stddev: 0.00022621010787575476) 128.51191203721672 iter/sec (stddev: 0.00026220735978772406) 3.41
benchmarks/unbinned_nll.py::test_unbinned_nll_estimator[numpy] 124.35434985283246 iter/sec (stddev: 0.00009557364942604139) 345.5347754466312 iter/sec (stddev: 0.00009775185162269724) 2.78
benchmarks/unbinned_nll.py::test_unbinned_nll_estimator[numba] 97.18704899505222 iter/sec (stddev: 0.0003010207023603398) 547.3808519863164 iter/sec (stddev: 0.00008040495616927644) 5.63

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pure, immutable ParametrizedFunction

3 participants