Skip to content

fix(offerings): slug 锁定错误带被拒新值(lib 部分,补 #486 漏提) #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sundevilyang merged 3 commits into from
Sep 9, 2026
Merged

fix(offerings): slug 锁定错误带被拒新值(lib 部分,补 #486 漏提) #488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1e9f9d
fix(offerings): slug 锁定错误带被拒新值(lib 部分,补 #486 漏提)
sundevilyang Sep 9, 2026
c41b853
fix(offerings): slug 锁定错误带被拒新值,消除 Value: nil 排障误导
sundevilyang Sep 9, 2026
364e848
Merge branch 'develop' into fix/slug-lock-error-value-lib
sundevilyang Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions backend/lib/cgc_2046/courses/course.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,9 @@ defmodule Cgc2046.Courses.Course do
Ash.Changeset.add_error(
changeset,
field: :slug,
# 带被拒新值——Ash keyword add_error 不传 :value 时错误消息 Value 恒为 nil,
# 排障时无法区分「参数丢失」与「锁定拦截」(2026-09-09 生产实例误判过)
value: Ash.Changeset.get_attribute(changeset, :slug),
message: "slug is locked once the offering is published (editable in draft only)"
)
else
Expand Down
3 changes: 3 additions & 0 deletions backend/lib/cgc_2046/events/event.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,9 @@ defmodule Cgc2046.Events.Event do
Ash.Changeset.add_error(
changeset,
field: :slug,
# 带被拒新值——Ash keyword add_error 不传 :value 时错误消息 Value 恒为 nil,
# 排障时无法区分「参数丢失」与「锁定拦截」(2026-09-09 生产实例误判过)
value: Ash.Changeset.get_attribute(changeset, :slug),
message: "slug is locked once the offering is published (editable in draft only)"
)
else
Expand Down
3 changes: 3 additions & 0 deletions backend/test/cgc_2046/events/event_slug_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,9 @@ defmodule Cgc2046.Events.EventSlugTest do

assert Exception.message(error) =~ "slug is locked"

# 错误须带被拒新值(可观测性:区分「参数丢失」与「锁定拦截」,2026-09-09 生产误判)
assert Exception.message(error) =~ ~s(Value: "new-slug")

assert Ash.get!(Event, event.id, tenant: workspace.id, authorize?: false).slug ==
"lock-open-event"
end
Expand Down
Loading