86eyt6teg: traffic signal job

[TibyanSaad]

• created a traffic signal table
• added a change in the signal status red ->yellow-> green -> red(again)
• added a trigger to start the change
• added a procedure to check the current state of a specific signal

[github-actions]

Here are the code review comments for the pull request:

Code Review Comments

• Title Issue: The title "86eyt6teg: traffic signal job" should start with the correct ClickUp ticket ID format. Please change it to "86eyt6teg: [Actual Title Here]".
• Description Improvement: The PR description should explicitly state the changes made, like adding procedures, updating states, and creating triggers. Revise the bullet points to clearly reflect the modifications.
• Indentation: Indentation should be consistently 4 spaces. Line 8 is not indented correctly.
• Blank Lines: There are several unnecessary blank lines throughout the code. Please remove them for cleaner formatting (lines 2, 11, 31, 59, 63, 78, 92).
• Logical Errors:
  • Typo in the comment on line 24: "Chceking" should be "Checking".
  • On line 39, the variable v_state is assigned VARCHAR2 but should include length (e.g., VARCHAR2(10)) for clarity and consistency.
• Trigger Initialization: In the trigger, make sure the procedure start_signal_watch is called in a way that ensures it won't interfere with the main workflow. There's a placeholder ("TO DO") on line 88, which should be replaced with an appropriate message or function.

Please address these issues to improve the code quality and compliance with project standards.

opencode session  |  github run

[CodelineAtyab]

any specific reason for adding a contaraint here ?

[CodelineAtyab]

indentation ?