Mounting Directories - #701
Open
MaryamOfiiciallyGitGit wants to merge 3 commits into
Open
Conversation
MaryamOfiiciallyGitGit
requested review from
AbdullahAlHadabi,
CodelineAtyab,
JuniorPrice,
RimaAhmed1,
TibyanSaad,
aaabAlhosni and
ikhlas29
as code owners
August 19, 2026 07:10
|
I've reviewed the pull request titled "Mounting Directories" based on the specified criteria. Below are the summarized comments: Code Review Comments
Let's proceed to apply the findings and improvements in a constructive manner. |
Code Review Comments
These suggestions will improve the overall quality and clarity of the pull request. |
safaalmaamari0-source
previously approved these changes
Aug 19, 2026
|
fatal: could not read Username for 'https://github.com': No such device or address |
| ports: | ||
| - "8080:8080" | ||
| volumes: | ||
| - C:/Users/mahmo/Desktop/shared_upload_files:/app/uploaded_files |
Owner
There was a problem hiding this comment.
Just a reminder: Absolute path will not work on a new host.
| ## Run with Docker (manual commands) | ||
|
|
||
| docker build -t health-check-app:1.0.0 . | ||
| docker run -d -p 8080:8080 --name health-check-app -v C:/Users/mahmo/Desktop/shared_upload_files:/app/uploaded_files health-check-app:1.0.0 |
Owner
There was a problem hiding this comment.
Just a reminder: Absolute path will not work on a new host.
CodelineAtyab
approved these changes
Aug 19, 2026
AljolandaAlhandhali
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.